From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC3B7C43331 for ; Sat, 28 Mar 2020 03:13:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB227206F1 for ; Sat, 28 Mar 2020 03:13:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bGSSab8e"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hw4n6WYF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB227206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R798NGFRFehQeAUM7m2CVXKy3Bwv3LFd/5HkZfVD370=; b=bGSSab8eR/xV/S UtEXDopsJnxZuBt9x1TYlk06ZAXJ8D6xmyiGEro9NLaf/yzDPpo7ReJXN5pvcHhO6eexruFrnoM/Z x7aR+gzFkF0NS5es7I4wloCChNY9RtB5T+hTkWFJxnGfgEEWGYhIYfy3gPG8xCsHeJ0lvfuwU/bpk XSKF0SH3ZPgbtvEiscSBAESROr7clVY7BnULuJQHbxyRP9sOEDINR1zkyjR1LF7pdbxIL7hiHfd8Z DDCpzw+7UjIzV2r8dKmmGlPm+ceF+2EabruPpAO2DxhfzZGxUWOf69GzXSJ6EZlrHQvaBJGDKPJMy hkTLiahaQx2lSa6wTQdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jI1uq-0006Nc-61; Sat, 28 Mar 2020 03:13:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jI1um-0006N0-25 for linux-nvme@lists.infradead.org; Sat, 28 Mar 2020 03:13:41 +0000 Received: from keith-busch (unknown [8.36.226.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C066B206F1; Sat, 28 Mar 2020 03:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585365218; bh=FbzAYDFJXzmdRzyIumoWFqteCyW0V2FlhYpXUFfmxzc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hw4n6WYF/b0nwXuMtAR4O8d9WF0AzmD48b21Onp+hN0hhauXFnKwFSwoDSbbLsKBR c9H+qxhk7BChOx18SfZS+Oy02BmkK7PtYEAuXFh50aQh3VYBbQyPtrXLFCadj36zug wsqbBMujsonkIfjskkxvzVy6wXXnto2/9GlAN5sM= Date: Fri, 27 Mar 2020 21:13:35 -0600 From: Keith Busch To: Ming Lei Subject: Re: [PATCH] block, nvme: Increase max segments parameter setting value Message-ID: <20200328031334.GA18429@keith-busch> References: <20200323182324.3243-1-ikegami.t@gmail.com> <20200324000237.GB15091@redsun51.ssa.fujisawa.hgst.com> <6b73db44-ca3f-4285-0c91-dc1b1a5ca9f1@gmail.com> <20200327181825.GA8356@redsun51.ssa.fujisawa.hgst.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200327_201340_127184_54B3439A X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-block@vger.kernel.org" , Tokunori Ikegami , Chaitanya Kulkarni , "linux-nvme@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sat, Mar 28, 2020 at 10:11:57AM +0800, Ming Lei wrote: > On Sat, Mar 28, 2020 at 2:18 AM Keith Busch wrote: > > > > This is actually even more confusing. We do not support 256MB transfers > > within a single command in the pci nvme driver anymore. The max is 4MB, > > so I don't see how increasing the max segments will help: you should be > > hitting the 'max_sectors' limit if you don't hit the segment limit first. > > That looks a bug for passthrough req, because 'max_sectors' limit is only > checked in bio_add_pc_page(), not done in blk_rq_append_bio(), something > like the following seems required: Shouldn't bio_map_user_iov() or bio_copy_user_iov() have caught the length limit before proceeding to blk_rq_append_bio()? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme