From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E18C43331 for ; Sat, 28 Mar 2020 05:10:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB2C320716 for ; Sat, 28 Mar 2020 05:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c2tF8A5d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB2C320716 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=draconx.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PA46n75oB1/JzDstwNxhp3lIV/wXWrj2sGMAuUHau/E=; b=c2tF8A5dywnZJE vwGy0MCUl40DYUC0PJWt1o7wUdN/RWOQ1jFZdFxEHTjPyPuoxCABe6e0O87Fzd2gNTPMBECqY/m6H tIVvszVSmy68qS4VqFmO+Y0iUFLzoXvaHT01SVVsKCe8+IqbIvYa+xT+oupST0IL4g7Xdw0AqRabe RlPyVV8/ffy780ML1ENsxBAxhml8W647zS4kWNgbfYMUW/bRyKRteZ9p6iwVl7jxhd9yU96xq/yco er9zMTDq5L5Uf1SSquLwnJJ3bJTfty9q1vtMR3+EpawLnG4rNqUXsCrvNfI7MAZ0EY/KH/5afpv8O M6sl8a5k8j+jrbzjbItg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jI3jz-0002W9-QG; Sat, 28 Mar 2020 05:10:39 +0000 Received: from mta01.start.ca ([162.250.196.97]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jI3jx-0002V3-G9 for linux-nvme@lists.infradead.org; Sat, 28 Mar 2020 05:10:38 +0000 Received: from mta01.start.ca (localhost [127.0.0.1]) by mta01.start.ca (Postfix) with ESMTP id 48D6F4290F; Sat, 28 Mar 2020 01:10:27 -0400 (EDT) Received: from localhost (dhcp-24-53-240-163.cable.user.start.ca [24.53.240.163]) by mta01.start.ca (Postfix) with ESMTPS id 0D973428FE; Sat, 28 Mar 2020 01:10:07 -0400 (EDT) From: Nick Bowler To: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/2] nvme: compat ioctl fixes Date: Sat, 28 Mar 2020 01:09:07 -0400 Message-Id: <20200328050909.30639-1-nbowler@draconx.ca> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200327_221037_601097_DDE6649C X-CRM114-Status: UNSURE ( 7.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Hellwig , Keith Busch , Sagi Grimberg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On review of my earlier patch to correct how 32-bit addresses in the NVME_IOCTL_ADMIN_CMD compat ioctl (via nvme_user_cmd function) were handled, similar problems were noted in the nvme_user_cmd64 function. Additionally, NVME_IOCTL_SUBMIT_IO is busted in the compat case because it not only has the same 32-bit address problem, but additionally the corresponding nvme_user_io structure padding differs between 32-bit and 64-bit x86 (and some other arches presumably have the same problem). Note that since I do not know of any users of the NVME_IOCTL_IO64_CMD or NVME_IOCTL_ADMIN64_CMD ioctls, I have not tested the changes to the nvme_user_cmd64 function (but these changes are virtually identical to those done in the other functions function). Nick Bowler (2): nvme: Fix compat NVME_IOCTL_SUBMIT_IO numbering nvme: Fix compat address handling in several ioctls drivers/nvme/host/core.c | 47 ++++++++++++++++++++++++--------- include/uapi/linux/nvme_ioctl.h | 25 ++++++++++++++++++ 2 files changed, 59 insertions(+), 13 deletions(-) -- 2.24.1 _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme