From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C73EBC43331 for ; Tue, 31 Mar 2020 15:55:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 859C220781 for ; Tue, 31 Mar 2020 15:55:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c2bI4JVr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 859C220781 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/LslJbLhLOi6/mlvHTujju4dL8vh1Z+wNatKMtUafBw=; b=c2bI4JVr0GG2u0 HJeYfs1TQrRezWYZnM73UN/vA/gfuaqyy5iTy4nJ/9hCOIEYk8by8jadOhXtGdmPvjG9Qpzzzb599 4aUEP4mq9kmdyl1ke5Ygex+EDRlZ92mErCU/eDyuxJEFq8N6zazAWQhLaryeAB1j29Ovc0EJXaJce Krld9N07ze3JbiNucZ9O9fQyn+bTols6Bc4kAO96tz2ONJCf9SyQq74AAzQ/u80vFoeQK8t/0Arud GYXeavnjFXZTBjGUcC3xuvVlZNemgSBpNOHmUxZt0AAnDa27urp4mbTh7DNmE3N9hJhx+kBEm7OAu 8vJlxgISaF9LWJm0x5zg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJJEs-0008Aw-2o; Tue, 31 Mar 2020 15:55:42 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJJCJ-0003Vr-8m for linux-nvme@lists.infradead.org; Tue, 31 Mar 2020 15:53:04 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6158468BFE; Tue, 31 Mar 2020 17:52:57 +0200 (CEST) Date: Tue, 31 Mar 2020 17:52:57 +0200 From: Christoph Hellwig To: Tejun Heo Subject: Re: [PATCH v5 0/4] Add support Weighted Round Robin for blkcg and nvme Message-ID: <20200331155257.GA22994@lst.de> References: <20200204154200.GA5831@redsun51.ssa.fujisawa.hgst.com> <20200331143635.GS162390@mtj.duckdns.org> <20200331155139.GT162390@mtj.duckdns.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200331155139.GT162390@mtj.duckdns.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200331_085303_455374_A8EE9B61 X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Weiping Zhang , linux-nvme@lists.infradead.org, Ming Lei , linux-block@vger.kernel.org, Minwoo Im , cgroups@vger.kernel.org, Keith Busch , "Nadolski, Edmund" , Thomas Gleixner , Christoph Hellwig , Bart Van Assche Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Mar 31, 2020 at 11:51:39AM -0400, Tejun Heo wrote: > Hello, > > On Tue, Mar 31, 2020 at 11:47:41PM +0800, Weiping Zhang wrote: > > Do you means drop the "io.wrr" or "blkio.wrr" in cgroup, and use a > > dedicated interface > > like /dev/xxx or /proc/xxx? > > Yes, something along that line. Given that it's nvme specific, it'd be best if > the interface reflects that too - e.g. through a file under > /sys/block/nvme*/device/. Jens, Christoph, what do you guys think? I'm pretty sure I voiced my opinion before - I think the NVMe WRR queueing concept is completely broken and I do not thing we should support it at all. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme