From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F0AC54FCB for ; Wed, 22 Apr 2020 16:57:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8162A20706 for ; Wed, 22 Apr 2020 16:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nRSvPRd9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8162A20706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4gKf1Ct4K3Ts8VsqsL1aZp3bn4lqFrnN3hNnaOOCHAw=; b=nRSvPRd9kOawWb j1Z8GAWblaBNaFUPsKT0CDWH38keVrIVNA/fmGRzGToNI+IBJ5XimqqNtFVA3986pDXUFDQvriCZh Bi//3ritLym6s7AbnLjFWrw4AosAoyd22FDuzbKPArwFpQgWNVJXWyrkmDnhZb6wS2lx3EpNasjQU 8LjIi2Qd4k4dAhFrsMvF35RC+dlxgPYmq8jVrte/bR+pN+BsKeqYyZZ5oA3wa0twAl5ySAgbuPWop CVGuOcSAEnF2TvnYi2MarCqBkel/0baIY32Xzqy6BtTfjQlwyd1CyFfAxvR+Ua1chR678mOlQGSmq H3LuAd2FzHrq4P8pEA6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRIgv-0002T8-N5; Wed, 22 Apr 2020 16:57:41 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRIgl-0002Em-57; Wed, 22 Apr 2020 16:57:31 +0000 Date: Wed, 22 Apr 2020 09:57:31 -0700 From: Christoph Hellwig To: weiping zhang Subject: Re: [PATCH] nvme: align io queue count with allocted nvme_queue in nvme_probe Message-ID: <20200422165731.GA8218@infradead.org> References: <20200410095719.GA4393@192.168.3.9> <188ad279-9211-9dca-3e6c-b5718ae6fc80@mellanox.com> <66add5c2-62b9-5c2d-977b-0499834b2b7a@mellanox.com> <20200422083747.GA26915@infradead.org> <20200422092416.GA12930@192.168.3.9> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200422092416.GA12930@192.168.3.9> X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Weiping Zhang , Weiping Zhang , linux-nvme@lists.infradead.org, Christoph Hellwig , Keith Busch , Max Gurtovoy , sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Apr 22, 2020 at 05:24:27PM +0800, weiping zhang wrote: > > The problem with PCIe is that we only have a per-controller interface > > once the controller is probed. So a global paramter that can be > > changed, but only is sampled once at probe time seems the easiest to > > me. We could also allow a per-controller sysfs file that only takes > > effect after a reset, which seems a little nicer, but adds a lot of > > boilerplate for just being a little nicer, so I'm not entirely sure > > if it is worth the effort. > Hi Christoph, > > Because in the real user case, the number of each type queue may > not very suitable, it needs a ability to adjust them without hotplug. > > If so, the nvme_dev needs record how many write/poll > queues saved in nvme_probe, and then use them in reset flow. When I wrote probe above I meant to include reset, sorry. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme