From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2760C55186 for ; Fri, 24 Apr 2020 07:12:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8D572075A for ; Fri, 24 Apr 2020 07:12:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KpWjwq6g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8D572075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IFCodhDU/NqhYeiMoFt41OBHdF62b5mLaMFO4EuqZoM=; b=KpWjwq6gKLZjH7 a0W/n4WANWsA0rojJUMvCT/W1AM9piBUSQh2GLXJwZ1P18PNMqX2lV0xTUwYYL44x+3UXcK5DE8Ue OSH0vcGMraChVMGZR2xUT+KK18vADNzKR770g0Cy2pZy+39UsItvToSCevc056Qzgql6ygS68xU+7 SMFJE3BnRYCwxluF9HG3fzXpmpa3AT4ymqJahYotOLPOfdBXyymIdwSFHAAxJ+C32fBCN43kVe/rH K9E6n2LGsI28+ND3MAE9N2DKYcNfU8dlfzu2DEplSvmI6zfgb2w3ayBaTFti4teLUH4ZbfVOz6nT4 ji2JRopKkfgXz0rfcMbQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRsVu-0005Fa-TK; Fri, 24 Apr 2020 07:12:42 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRsVs-0005EK-Q3 for linux-nvme@lists.infradead.org; Fri, 24 Apr 2020 07:12:42 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2435168CEE; Fri, 24 Apr 2020 09:12:38 +0200 (CEST) Date: Fri, 24 Apr 2020 09:12:37 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 13/17] nvme: Add Metadata Capabilities enumerations Message-ID: <20200424071237.GD24059@lst.de> References: <20200327171545.98970-1-maxg@mellanox.com> <20200327171545.98970-15-maxg@mellanox.com> <20200421152407.GD10837@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200424_001240_994299_DE8044C8 X-CRM114-Status: UNSURE ( 8.05 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, jsmart2021@gmail.com, sagi@grimberg.me, martin.petersen@oracle.com, shlomin@mellanox.com, linux-rdma@vger.kernel.org, israelr@mellanox.com, vladimirk@mellanox.com, linux-nvme@lists.infradead.org, idanb@mellanox.com, jgg@mellanox.com, oren@mellanox.com, kbusch@kernel.org, Christoph Hellwig Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Apr 23, 2020 at 03:09:47PM +0300, Max Gurtovoy wrote: > > On 4/21/2020 6:24 PM, Christoph Hellwig wrote: >> On Fri, Mar 27, 2020 at 08:15:41PM +0300, Max Gurtovoy wrote: >>> From: Israel Rukshin >>> >>> The enumerations will be used to expose the namespace metadata format by >>> the target. >>> >>> Signed-off-by: Israel Rukshin >>> Reviewed-by: Max Gurtovoy >> I'd be tempted to use a separate enum and add a comment to which field >> this relates. > > something like: > > +/* Metadata Capabilities */ > +enum { > +=A0=A0=A0=A0=A0=A0 /* supports metadata being transferred as part of an = extended LBA */ > +=A0=A0=A0=A0=A0=A0 NVME_NS_MC_META_EXT=A0=A0=A0=A0 =3D 1 << 0, > +=A0=A0=A0=A0=A0=A0 /* supports metadata being transferred as part of a s= eparate = > buffer */ > +=A0=A0=A0=A0=A0=A0 NVME_NS_MC_META_BUF=A0=A0=A0=A0 =3D 1 << 1, > +}; What about: /* Identify Namespace Metadata Capabilities (MC): */ enum { NVME_MC_METADATA_PTR =3D (1 << 0), NVME_MC_EXTENDED_LBA =3D (1 << 1), }; _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme