From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B500DC47256 for ; Wed, 6 May 2020 04:27:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F923206DD for ; Wed, 6 May 2020 04:27:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fs5/B6ys" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F923206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZhcEnrro4LBQAnD8B2GnGvJFCm7RLEe8twmdcxZ/GXY=; b=fs5/B6yshZ5rtc D7PPQdlq9VsI5bxgCaXUzS6G/DdLpDjUuPIQ6a558kScMg+MvnEiXV8+ZWF+cZNGzr2jlrbtItYSl PHKlKe+YJgCteEWK5Tvgx7/aCTCPPOgb1TapL803zBQtSmNjguhw2lez83pbQLj2MgWMlY8G5XYrj nJ7qF2XU1I7WgIEalmyC7Y5p5ChLxFfH1Jvf5RuBfpRtpPl7Y5hQgGs1YrSlAQGyyTxL7HIk70+Rw 2mvbqRjL5PjxZzrDC8Pg4TI891kmFvuDbpptD9r4Q6gaUXb7UFxZhCZBUOs2iR+0mJD0bJbigVlAR 7QwmQ3JgsoKXS0x/U64w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWBeq-0001oy-AS; Wed, 06 May 2020 04:27:44 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWBel-0001oV-L6 for linux-nvme@lists.infradead.org; Wed, 06 May 2020 04:27:42 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 1C85068C4E; Wed, 6 May 2020 06:27:35 +0200 (CEST) Date: Wed, 6 May 2020 06:27:34 +0200 From: Christoph Hellwig To: Sagi Grimberg Subject: Re: [PATCH 1/2] nvme-tcp: set MSG_SENDPAGE_NOTLAST with MSG_MORE when we have more to send Message-ID: <20200506042734.GA9542@lst.de> References: <20200505052002.14924-1-sagi@grimberg.me> <20200505060907.GA3995@lst.de> <20200505102354.GB15038@lst.de> <6abf2183-ea1e-d1e0-360c-5d74b75c3690@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6abf2183-ea1e-d1e0-360c-5d74b75c3690@grimberg.me> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200505_212741_101327_C4B70E0A X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Mark Wunderlich , Anil Vasudevan , Christoph Hellwig , linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, May 05, 2020 at 02:53:40PM -0700, Sagi Grimberg wrote: >> What I mean is that nvmet_try_send_data and nvmet_try_send_ddgst may set >> neither MS_MORE nor MSG_EOR. Is that intentional? > > nvmet_try_send_data should set MSG_EOR if it doesn't have more to send > and also nvmet_try_send_ddgst. So its not intentional. Ok. Can you send it with a little helper like I suggested (probably one each for host and target) that ensures the right flags are set everywhere? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme