From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CECEBC433DF for ; Thu, 21 May 2020 13:34:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7413F2078B for ; Thu, 21 May 2020 13:34:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V8Rd2EOB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A1yY0pcU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7413F2078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A7qj/vOHzq0zPp/T3YqUZvLFN4yF/FO1km488xxig4M=; b=V8Rd2EOBYeMs3m E16/37B1CbPwl2EcvhUeknJtRZqKkYOnMoHq254jRTZtx/YhaXAIFa3U3zymmW6thIfxt7zuLWtp+ wPGWKVrVeL51sIxseqYJ0bdYWizTBM8mnSbox2HmZjEa/HVyrcO3S2bMHzp4lnc2ZkyM09l+D9UAS ENMdqWZVLjIuKyQp9yoZE11sm0CllLZeaGMriG8B+NWR+TP1CoGjQkH1+cbyfAkhZlUR1mZvJi4w6 YIHO3PRil4qQom/F/StS9q1LzsL/AgobaU1aHIzDx7CWXTQ7bLmMXCa6AbAY+YiQcJiXw37uKfsTB Vr3K6ZaH2CU+lbJe+rUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jblKs-0004lq-Bf; Thu, 21 May 2020 13:34:10 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jblKc-0004Uh-CT; Thu, 21 May 2020 13:33:56 +0000 Received: by mail-qt1-x844.google.com with SMTP id m44so5425038qtm.8; Thu, 21 May 2020 06:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EQm3KwRvgaHxQ5d1Q4EsqwYQDDPz8ESa9iFyt4vvvfU=; b=A1yY0pcUPS8ck0PV+oiK0L7Xz4/CMf99HFvZLNGUwtkmJl1HZgyPoRsWMMpkPViZh0 g5zjGf3xBdccjZCBDrDAtY8wQjaBZ20OxMUJOX2ygsAZmQ7FAOTD578Pi8cO/AGsz/0k +6GEYqQqrDeTvrPiNG4dFgi17HrIhPWpILlQe2Haz/tBvylaHUHhtLMH1x1JgMBfFxbG dVhzC9D5lQnZ9bUPGy2DvBKfUkckuBYamDN1KFet5x5I1KxpS/Xd/0nP+OBlUFjYmTJ3 d3tseyuZBcS/wV3owA0JIbRvtw028OV+O6ZJMOkqyJt0SMGeOHIN4l7beBYArRlnUqQR Cj1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EQm3KwRvgaHxQ5d1Q4EsqwYQDDPz8ESa9iFyt4vvvfU=; b=PwVWMD3oNf9wn3O5hnI0DdvUdb6QIsVy9G0yx8CpblDQZsa192fZnc6aZ5JHQNMhZb zH6kZQJ8EW6cqDDFUgUj3uZR7gVmgAq0Em+rIDh6JoSKeTr4V6RpjeXSp/nKYz8AokOP LwO+Oz8a6fzEUECebr3tWOXdHZcsnBbPxFtMnDpHFqwC8FtBoYkuaseC82EojVqaVGqq rzfW9pA+E5pnJ/olmnR8uLO5rAhcuQBTeVf39jquPQVhYs032K60milPp0P8Vsx7i5pT mvUzWfiTjnWKJhcvQvdqDkUJmjNvlfpJG3aGeKIZA+pmeb3lPxu/akpY9XJg3deHJBzg 61dw== X-Gm-Message-State: AOAM533VPYqZDma4SKw0svlSWas48iaUsglqpgxAyoO476/JTy0TKEjW 7pEWVvPqZ4k+WRUCK20AZIw= X-Google-Smtp-Source: ABdhPJzWBT98PJLkbYawA91UQ6OHszxicgo3NkwFTGAv08qIHw76JSy/EnOeEfPbcxMUsuNECRy/Lw== X-Received: by 2002:aed:2bc4:: with SMTP id e62mr11045622qtd.263.1590068031488; Thu, 21 May 2020 06:33:51 -0700 (PDT) Received: from localhost.localdomain ([168.181.48.225]) by smtp.gmail.com with ESMTPSA id l184sm4861282qke.115.2020.05.21.06.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 06:33:50 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 3AF26C0BEB; Thu, 21 May 2020 10:33:48 -0300 (-03) Date: Thu, 21 May 2020 10:33:48 -0300 From: Marcelo Ricardo Leitner To: Christoph Hellwig Subject: Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay Message-ID: <20200521133348.GX2491@localhost.localdomain> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> <20200520233913.GV2491@localhost.localdomain> <20200521083442.GA7771@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200521083442.GA7771@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_063354_927545_A8D6CA27 X-CRM114-Status: GOOD ( 18.29 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edumazet@google.com, linux-nvme@lists.infradead.org, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, kuznet@ms2.inr.ac.ru, kuba@kernel.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, nhorman@tuxdriver.com, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, vyasevich@gmail.com, linux-kernel@vger.kernel.org, jmaloy@redhat.com, ying.xue@windriver.com, David Miller , ocfs2-devel@oss.oracle.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, May 21, 2020 at 10:34:42AM +0200, Christoph Hellwig wrote: > On Wed, May 20, 2020 at 08:39:13PM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > > > From: Marcelo Ricardo Leitner > > > Date: Wed, 20 May 2020 20:10:01 -0300 > > > > > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > > > API could be a bit more complete than that. > > > > > > The APIs are being designed based upon what in-tree users actually > > > make use of. We can expand things later if necessary. > > > > Sometimes expanding things later can be though, thus why the worry. > > But ok, I get it. Thanks. > > > > The comment still applies, though. (re the duplication) > > Where do you see duplication? > > sctp_setsockopt_nodelay does the following things: > > - verifies optlen, returns -EINVAL if it doesn't match > - calls get_user, returns -EFAULT on error > - converts the value from get_user to a boolean and assigns it > to sctp_sk(sk)->nodelay > - returns 0. > > sctp_sock_set_nodelay does: > > - call lock_sock > - assign true to sctp_sk(sk)->nodelay > - call release_sock > - does not return an error code With the patch there are now two ways of enabling nodelay. It may be just a boolean set today, but if one wants to probe on it or if we want to extend it with anything, say a debug msg, we have to do it in two (very different) places. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme