From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4510AC433E1 for ; Tue, 16 Jun 2020 14:26:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20E6520882 for ; Tue, 16 Jun 2020 14:26:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="edABS3K9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20E6520882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TBcRw7a5czQ1d9m7J/lDZNNX5N2ASPqgN/85LRx227E=; b=edABS3K9Z2utbD GtetL/f8+yy/Mcfyr4HVXhlyx+BbUk2WdujphoKw3G4GGLXhUO7yyKpdEksYebuhB2KDJm/MLp5Qp 9jCjZkUgsR738aDEXejzfYLv6Dn/S8LdQGI0Z71o0u3as7kLz+u+PjhFoCC9uZCcdDwpqEJlRVWM4 8GrLSyQ7YoWEhwsJ39YFeHotjW/0ZQTrRBGFEOMgqGs+Yc8MAl2Zvo7BpI5YP0VOr3US1oJUNJh43 Xb69mUe/JmRn+5OaxDjmYGMK1TFY4YoRNrBcNg1g0xTSGIsKVtRVckiKGRaEKL5WvSSK7V3tCgbi7 yKjrosOu8F6c8+LvN2yA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlCY2-00010e-7A; Tue, 16 Jun 2020 14:26:46 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlCQV-00077Z-EK for linux-nvme@lists.infradead.org; Tue, 16 Jun 2020 14:19:03 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 14ACFABE4; Tue, 16 Jun 2020 14:19:01 +0000 (UTC) Date: Tue, 16 Jun 2020 16:18:55 +0200 From: Daniel Wagner To: Keith Busch Subject: Re: [PATCH 2/5] null_blk: introduce zone capacity for zoned device Message-ID: <20200616141855.4opiywhfbo7sa7nu@beryllium.lan> References: <20200615233424.13458-1-keith.busch@wdc.com> <20200615233424.13458-3-keith.busch@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200615233424.13458-3-keith.busch@wdc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200616_071859_751840_C29C83FB X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Damien Le Moal , Sagi Grimberg , Aravind Ramesh , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Christoph Hellwig , Matias =?utf-8?B?QmrDuHJsaW5n?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Jun 16, 2020 at 08:34:21AM +0900, Keith Busch wrote: > From: Aravind Ramesh > > Allow emulation of a zoned device with a per zone capacity smaller than > the zone size as as defined in the Zoned Namespace (ZNS) Command Set > specification. The zone capacity defaults to the zone size if not > specified and must be smaller than the zone size otherwise. > > Signed-off-by: Aravind Ramesh Just a little nitpick. Reviewed-by: Daniel Wagner > --- > drivers/block/null_blk.h | 2 ++ > drivers/block/null_blk_main.c | 9 ++++++++- > drivers/block/null_blk_zoned.c | 17 +++++++++++++++-- > 3 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/null_blk.h b/drivers/block/null_blk.h > index 81b311c9d781..7eadf190528c 100644 > --- a/drivers/block/null_blk.h > +++ b/drivers/block/null_blk.h > @@ -44,11 +44,13 @@ struct nullb_device { > unsigned int nr_zones; > struct blk_zone *zones; > sector_t zone_size_sects; > + sector_t zone_capacity_sects; > > unsigned long size; /* device size in MB */ > unsigned long completion_nsec; /* time in ns to complete a request */ > unsigned long cache_size; /* disk cache size in MB */ > unsigned long zone_size; /* zone size in MB if device is zoned */ > + unsigned long zone_capacity; /* zone cap in MB if device is zoned */ Maybe also use zone capacity in the comment instead of the abbreviation? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme