From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme: fix identify error status silent ignore
Date: Thu, 25 Jun 2020 13:50:06 +0000 [thread overview]
Message-ID: <20200625135004.GA427904@localhost.localdomain> (raw)
In-Reply-To: <20200625000257.29981-1-sagi@grimberg.me>
On Wed, Jun 24, 2020 at 05:02:57PM -0700, Sagi Grimberg wrote:
> Patch 59c7c3caaaf8 intended to only silently ignore
> non retry-able errors (DNR bit set) such that we can still
> identify misbehaving controllers, and in the other hand
> propagate retry-able errors (DNR bit cleared) so we don't
> wrongly abandon a namespace just because it happens to be
> temporarily inaccessible.
>
> The goal remains the same as the original commit where this
> was introduced but unfortunately had the logic backwards.
>
> Fixes: 59c7c3caaaf8 ("nvme: fix possible hang when ns
> scanning fails during error recovery")
> Reported-by: Keith Busch <kbusch@kernel.org>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 2afed32d3892..3e84ab6c2bd3 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1130,7 +1130,7 @@ static int nvme_identify_ns_descs(struct nvme_ctrl *ctrl, unsigned nsid,
> * Don't treat an error as fatal, as we potentially already
> * have a NGUID or EUI-64.
> */
> - if (status > 0 && !(status & NVME_SC_DNR))
> + if (status > 0 && (status & NVME_SC_DNR))
The extra parentheses can also be dropped now when the there is no longer
any need for negation.
Kind regards,
Niklas
> status = 0;
> goto free_data;
> }
> --
> 2.25.1
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-06-25 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 0:02 [PATCH] nvme: fix identify error status silent ignore Sagi Grimberg
2020-06-25 13:50 ` Niklas Cassel [this message]
2020-06-25 17:06 ` Keith Busch
2020-06-25 18:13 ` Sagi Grimberg
2020-06-26 8:24 ` Christoph Hellwig
2020-06-28 5:28 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2020-06-24 23:56 Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625135004.GA427904@localhost.localdomain \
--to=niklas.cassel@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox