From: kernel test robot <lkp@intel.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: kbuild-all@lists.01.org, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: [RFC PATCH linux-nvme] nvme: dev_attr_ctrl_loss_tmo can be static
Date: Tue, 7 Jul 2020 18:50:17 +0800 [thread overview]
Message-ID: <20200707105017.GA3658@42360abf9c00> (raw)
In-Reply-To: <202007071822.30Odtc0k%lkp@intel.com>
Fixes: 3be72d5b2ac2 ("nvme: expose reconnect_delay and ctrl_loss_tmo via sysfs")
Signed-off-by: kernel test robot <lkp@intel.com>
---
core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 9de93298bd81b..088608714451f 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3564,7 +3564,7 @@ static ssize_t nvme_ctrl_loss_tmo_store(struct device *dev,
opts->reconnect_delay);
return count;
}
-DEVICE_ATTR(ctrl_loss_tmo, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(ctrl_loss_tmo, S_IRUGO | S_IWUSR,
nvme_ctrl_loss_tmo_show, nvme_ctrl_loss_tmo_store);
static ssize_t nvme_ctrl_reconnect_delay_show(struct device *dev,
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-07-07 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 10:50 [linux-nvme:nvme-5.9 34/40] drivers/nvme/host/core.c:3567:1: sparse: sparse: symbol 'dev_attr_ctrl_loss_tmo' was not declared. Should it be kernel test robot
2020-07-07 10:50 ` kernel test robot [this message]
2020-07-07 10:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707105017.GA3658@42360abf9c00 \
--to=lkp@intel.com \
--cc=hch@lst.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox