From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6BC9C433DF for ; Fri, 14 Aug 2020 10:34:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69087206A4 for ; Fri, 14 Aug 2020 10:34:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mlO5RR9S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69087206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GVWZYQ8zltLBBxX8J7T83p52AbPjkCPfG7/8yma9O2E=; b=mlO5RR9S3r2KGh70EVGTg5Jxp WcPatY6i6GQ+THO4Tsk3a9AIMCa5kPl9iXHPPGy0C0RtpNoJAXTfDeCgBi3OQagmhoN0f/yzGn6sM RKVQV3fFpvGHNoQupZW0VBZm5RxkLbkpg5ArHwnqDKJs8Kkz91luSbGLYPXfHG7fbZTaazKmKIuth +yo/lSfW5COK6tskoAj78YKWiEdT0e+K4Xw8GdEdPOtKsO782yHu+n1bP3kIWb7e+YseythNPKyHR qSPMD47TZ/M9OLjibOFEOP20+Hug1IRvp5G/SE5iJ4Pk+OqH98ZG4TqHxT3CAly0QKVRJL+seeMJw X7MlT5TCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6X2B-0003s4-IB; Fri, 14 Aug 2020 10:34:03 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6X27-0003p1-Ap for linux-nvme@lists.infradead.org; Fri, 14 Aug 2020 10:34:00 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 8C8B068C4E; Fri, 14 Aug 2020 12:33:56 +0200 (CEST) Date: Fri, 14 Aug 2020 12:33:56 +0200 From: "hch@lst.de" To: Logan Gunthorpe Subject: Re: [PATCH 01/14] nvmet: for pt I/O cmds annotate req->sg_cnt likely Message-ID: <20200814103356.GA20513@lst.de> References: <20200810185456.7713-1-chaitanya.kulkarni@wdc.com> <20200810185456.7713-2-chaitanya.kulkarni@wdc.com> <53dd1aa6-31a7-a9bd-6def-5cc18468845e@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200814_063359_954947_1A1A846E X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , Chaitanya Kulkarni , "hch@lst.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Aug 10, 2020 at 04:55:54PM -0600, Logan Gunthorpe wrote: > > > On 2020-08-10 4:54 p.m., Chaitanya Kulkarni wrote: > > On 8/10/20 14:54, Logan Gunthorpe wrote: > >> Hey, > >> > >> You forgot to CC me again.... > >> > > Ugghhh.. > >> On 2020-08-10 12:54 p.m., Chaitanya Kulkarni wrote: > >>> I/O Commands (nvme_cmd_read, nvme_cmd_write) are most command commands > >>> when accessing passthru controller. For I/O commands data is represented > >>> in SG list, so sg_cnt != 0 in most cases. > >>> > >>> Annotate req->sg_cnt check with likely. > >> Does adding these likely annotations actually produce any benefit? Why > >> can't we rely on the branch predictor in these instances? > >> > > > > They are present in the target code. I don't see any problem having it > > in a passthru code unless it shows severe performance degradation. > > Isn't that backwards? Don't we only add performance optimizations (which > likely/unlikely are) when they show demonstrable increases in performance? Yes, this looks like pretty premature optimization. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme