From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8585C433E1 for ; Fri, 14 Aug 2020 10:37:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92A93206A4 for ; Fri, 14 Aug 2020 10:37:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yLToaHC4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92A93206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3SZU3DSaY6JDrLyvAmOne+XBklrE7Vd5t2x03gDRqrA=; b=yLToaHC4CrFurEDJSLpVzwUCh X+OWCC/aaQU1I43mjw+B8madx1KWnpBlwDtUVtq7mH+XXhunRS28X3fcRNfaG+chtgALmYQdmtgcN lQFpF0TcutZwbl7/l/lebroO4a3z7PF87cMLjCreWj5mXhReOU1MeOhDB4z3mO2m6zSfMexwb3vBJ jXasTdhM+ADfA1xsVn7FDKCYzG5fKd9uoEKMwluKiVLCbs38rFysEINYIMEVLR9Zh4MmlyxkQSDpW v0M5L0lTx42sJcrIHg/8xjyqd7WxB087MOPLkWG7jB0cx3Z1guQVfSFP6MEX3tkA+2EspyeUXBQe1 uLUvT87BQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6X5E-0004rY-Nx; Fri, 14 Aug 2020 10:37:12 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6X5B-0004r0-IH for linux-nvme@lists.infradead.org; Fri, 14 Aug 2020 10:37:10 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E830568C4E; Fri, 14 Aug 2020 12:37:06 +0200 (CEST) Date: Fri, 14 Aug 2020 12:37:06 +0200 From: "hch@lst.de" To: Chaitanya Kulkarni Subject: Re: [PATCH 07/14] nvmet: reuse pt-req-done for rq completion Message-ID: <20200814103706.GB20513@lst.de> References: <20200810185456.7713-1-chaitanya.kulkarni@wdc.com> <20200810185456.7713-8-chaitanya.kulkarni@wdc.com> <367b5571-2981-8389-a5fe-f0bea20d2e33@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200814_063710_347404_1879A912 X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Logan Gunthorpe , "hch@lst.de" , "linux-nvme@lists.infradead.org" , "sagi@grimberg.me" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Aug 10, 2020 at 11:02:01PM +0000, Chaitanya Kulkarni wrote: > On 8/10/20 15:10, Logan Gunthorpe wrote: > > Christoph had specifically requested open coding this in earlier feedback: > > > > https://lore.kernel.org/linux-block/20191010123406.GC28921@lst.de/ > > > > It was originally called nvmet_passthru_req_complete() and was open > > coded at his request. > > > > I think the way it was merged ended up being cleaner and easier to read > > as well. > > > > Logan > > I don't understand the reason for this ? Christoph can you please explain ? Because this just happens to be a few lines of code that looks the same. But they are called from different context - one is a callback and thus has an extra argument for example. I don't see how sharing that code really improves anything. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme