From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45794C433E1 for ; Sat, 15 Aug 2020 06:55:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1281721744 for ; Sat, 15 Aug 2020 06:55:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X6J2Wf7P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1281721744 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gWNZPADbegfloeBZa6ZEw3tj4Mat2qxeDvNKaaGKWjg=; b=X6J2Wf7PxeZZzCzRtLVbupQlq gtT6lA23MWT9bUZkxzXhRbTvKfvdd3zAEdH8NRb/3aO7NQ0w5ddOStgWZJOylSLPtSD3sii9Zt0Uf h9nbxfLzDBB3IUJMlzwn30LGIpqTas8qkB2M2zcYMof9NmP2bHQanoJOxVwCpbuQ4rz/OfthAKybr 8qyCW2c6alGm7HCfsCiZGXI0no29S0eaOKd/MgxrULX/2bb/H++atfyBKa02dZYbP/iR3W+GCwX0H E4XNb/DGfTTduxNnwqY3RMZrlTAOpwrW+O1ErerefUIEBQ+8zkVuEUznY81zne95Gxbkp5Hy/8eHG 0GM4hTvYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6q6F-0005Gx-RJ; Sat, 15 Aug 2020 06:55:31 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6q6D-0005GY-Jl for linux-nvme@lists.infradead.org; Sat, 15 Aug 2020 06:55:30 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 0204768CF0; Sat, 15 Aug 2020 08:55:26 +0200 (CEST) Date: Sat, 15 Aug 2020 08:55:26 +0200 From: Christoph Hellwig To: Sagi Grimberg Subject: Re: [PATCH 3/3] nvme: redirect commands on dying queue Message-ID: <20200815065526.GB15518@lst.de> References: <20200814151528.277465-1-hch@lst.de> <20200814151528.277465-4-hch@lst.de> <02f6276a-bbb5-5185-6a4a-1ac7aa938399@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <02f6276a-bbb5-5185-6a4a-1ac7aa938399@grimberg.me> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200815_025529_830169_684E137D X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Christoph Hellwig , linux-nvme@lists.infradead.org, Chao Leng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Aug 14, 2020 at 11:44:12AM -0700, Sagi Grimberg wrote: > >> If a command send through nvme-multupath failed on a dying queue, resend it >> on another path. > > So this is a race where we got a retry-able status from the controller > (not from the host teardwon sequence) and we just happen to see > a dying queue? I think so, maybe Chao can explain the scenario in a little more detail. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme