From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Chao Leng <lengchao@huawei.com>
Subject: Re: [PATCH 3/4] nvme: just check the status code type in nvme_is_path_error
Date: Mon, 17 Aug 2020 11:11:16 -0400 [thread overview]
Message-ID: <20200817151116.GC30005@redhat.com> (raw)
In-Reply-To: <20200817081544.837699-4-hch@lst.de>
On Mon, Aug 17 2020 at 4:15am -0400,
Christoph Hellwig <hch@lst.de> wrote:
> Check the SCT sub-field for a path related status instead of enumerating
> invididual status code. As of NVMe 1.4 this adds "Internal Path Error"
> and "Controller Pathing Error" to the list, but it also future proofs for
> additional status codes added to the category.
>
> Suggested-by: Chao Leng <lengchao@huawei.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Ah, this is why you carried the duplicate checks in 2/4's
nvme_is_path_error and nvme_is_ana_error, makes sense.
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-17 15:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 8:15 nvme completion handling refactor and fix v2 Christoph Hellwig
2020-08-17 8:15 ` [PATCH 1/4] nvme: rename and document nvme_end_request Christoph Hellwig
2020-08-17 14:53 ` Mike Snitzer
2020-08-17 8:15 ` [PATCH 2/4] nvme: refactor command completion Christoph Hellwig
2020-08-17 15:08 ` Mike Snitzer
2020-08-17 19:28 ` Mike Snitzer
2020-08-18 6:26 ` Christoph Hellwig
2020-08-17 8:15 ` [PATCH 3/4] nvme: just check the status code type in nvme_is_path_error Christoph Hellwig
2020-08-17 15:11 ` Mike Snitzer [this message]
2020-08-17 19:31 ` Sagi Grimberg
2020-08-18 6:31 ` Christoph Hellwig
2020-08-17 8:15 ` [PATCH 4/4] nvme: redirect commands on dying queue Christoph Hellwig
2020-08-17 15:23 ` Mike Snitzer
2020-08-18 6:32 ` Christoph Hellwig
2020-08-17 18:10 ` nvme completion handling refactor and fix v2 Sagi Grimberg
2020-08-18 6:33 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-08-18 7:11 nvme completion handling refactor and fix v3 Christoph Hellwig
2020-08-18 7:11 ` [PATCH 3/4] nvme: just check the status code type in nvme_is_path_error Christoph Hellwig
2020-08-19 21:50 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817151116.GC30005@redhat.com \
--to=snitzer@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).