From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Keith Busch <kbusch@kernel.org>, Chao Leng <lengchao@huawei.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 2/4] nvme: refactor command completion
Date: Tue, 18 Aug 2020 08:26:16 +0200 [thread overview]
Message-ID: <20200818062616.GA1754@lst.de> (raw)
In-Reply-To: <20200817192859.GA31161@redhat.com>
On Mon, Aug 17, 2020 at 03:28:59PM -0400, Mike Snitzer wrote:
> > - blk_status_t status = nvme_error_status(nvme_req(req)->status);
> > + u16 status = nvme_req(req)->status & 0x7ff;
> >
> > - trace_nvme_complete_rq(req);
> > + if (likely(status == 0))
> > + return COMPLETE;
> >
> > - nvme_cleanup_cmd(req);
> > + if (blk_noretry_request(req) || (status & NVME_SC_DNR) ||
> > + nvme_req(req)->retries >= nvme_max_retries)
> > + return COMPLETE;
>
> Looking just a bit closer, the above DNR test seems wrong because of the
> 0x7ff mask applied. That mask drops access to NVME_SC_DNR right?
Indeed. And the whole masking is rather pointless as
nvme_is_path_error already performs it as well..
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-18 6:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 8:15 nvme completion handling refactor and fix v2 Christoph Hellwig
2020-08-17 8:15 ` [PATCH 1/4] nvme: rename and document nvme_end_request Christoph Hellwig
2020-08-17 14:53 ` Mike Snitzer
2020-08-17 8:15 ` [PATCH 2/4] nvme: refactor command completion Christoph Hellwig
2020-08-17 15:08 ` Mike Snitzer
2020-08-17 19:28 ` Mike Snitzer
2020-08-18 6:26 ` Christoph Hellwig [this message]
2020-08-17 8:15 ` [PATCH 3/4] nvme: just check the status code type in nvme_is_path_error Christoph Hellwig
2020-08-17 15:11 ` Mike Snitzer
2020-08-17 19:31 ` Sagi Grimberg
2020-08-18 6:31 ` Christoph Hellwig
2020-08-17 8:15 ` [PATCH 4/4] nvme: redirect commands on dying queue Christoph Hellwig
2020-08-17 15:23 ` Mike Snitzer
2020-08-18 6:32 ` Christoph Hellwig
2020-08-17 18:10 ` nvme completion handling refactor and fix v2 Sagi Grimberg
2020-08-18 6:33 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-08-18 7:11 nvme completion handling refactor and fix v3 Christoph Hellwig
2020-08-18 7:11 ` [PATCH 2/4] nvme: refactor command completion Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818062616.GA1754@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).