From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A17C433E1 for ; Tue, 18 Aug 2020 06:26:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 810C420825 for ; Tue, 18 Aug 2020 06:26:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cD9xR1cR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 810C420825 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RJ72aEUz8bR0kuLC73zvCBjcHZeR4uAKv26twwmYOWE=; b=cD9xR1cR3UuL65368y1NIWHEI C+Nk87N9uWMOzGKjWBi+zSNpOsT2x+9uTbaLlZVcTeTg2ymtZIPKe0jvmTwkSENu2s/hq2meQqbaC U2u15pY1mLNsX1sl44uohbi03GA3Rw6GaN69ELX+MB8NEDrESFMhOBCU5bhXEZOuEOJVKxvie/LSe FmTeSZnc0/GwA/gaaVgTEBQRs7E6WfaxP4SMjwsx0ClmpWOT7M7/S3xWn0b2hqVn7NcL3dNOMYIaF 8iz6fO62Ml7N3cjgBMgP/56UWHl675GUtwHcNrOXvDn/YlMqytu+OzRanQgBeg5/GXsYt2W0Ns10a BhzTPVTNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7v4k-00035I-Rr; Tue, 18 Aug 2020 06:26:26 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7v4i-00034Y-GB for linux-nvme@lists.infradead.org; Tue, 18 Aug 2020 06:26:25 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id EDBDD68B02; Tue, 18 Aug 2020 08:26:16 +0200 (CEST) Date: Tue, 18 Aug 2020 08:26:16 +0200 From: Christoph Hellwig To: Mike Snitzer Subject: Re: [PATCH 2/4] nvme: refactor command completion Message-ID: <20200818062616.GA1754@lst.de> References: <20200817081544.837699-1-hch@lst.de> <20200817081544.837699-3-hch@lst.de> <20200817192859.GA31161@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200817192859.GA31161@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_022624_712410_2AB63134 X-CRM114-Status: GOOD ( 10.80 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Chao Leng , Christoph Hellwig , linux-nvme@lists.infradead.org, Sagi Grimberg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Aug 17, 2020 at 03:28:59PM -0400, Mike Snitzer wrote: > > - blk_status_t status = nvme_error_status(nvme_req(req)->status); > > + u16 status = nvme_req(req)->status & 0x7ff; > > > > - trace_nvme_complete_rq(req); > > + if (likely(status == 0)) > > + return COMPLETE; > > > > - nvme_cleanup_cmd(req); > > + if (blk_noretry_request(req) || (status & NVME_SC_DNR) || > > + nvme_req(req)->retries >= nvme_max_retries) > > + return COMPLETE; > > Looking just a bit closer, the above DNR test seems wrong because of the > 0x7ff mask applied. That mask drops access to NVME_SC_DNR right? Indeed. And the whole masking is rather pointless as nvme_is_path_error already performs it as well.. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme