From: Christoph Hellwig <hch@lst.de>
To: amit.engel@dell.com
Cc: hch@lst.de, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet: Set ctrl->kato to a default NVMET_DISC_KATO value
Date: Tue, 18 Aug 2020 18:27:31 +0200 [thread overview]
Message-ID: <20200818162731.GC27196@lst.de> (raw)
In-Reply-To: <20200818065114.57532-1-amit.engel@dell.com>
On Tue, Aug 18, 2020 at 09:51:14AM +0300, amit.engel@dell.com wrote:
> From: Amit Engel <amit.engel@dell.com>
>
> We want to avoid starting the keep-alive timer with a zero timeout value
So looking at the spec:
"This field specifies the timeout value for the Keep Alive feature in
milliseconds. The controller rounds up the value specified to the granularity
indicated in the KAS
field in the Identify Controller data structure. If cleared to 0h, then the
Keep Alive Timer is disabled."
we should not just set a random high timeout but just disable the
keep alive entirely.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-18 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 6:51 [PATCH] nvmet: Set ctrl->kato to a default NVMET_DISC_KATO value amit.engel
2020-08-18 16:27 ` Christoph Hellwig [this message]
2020-08-18 20:54 ` Sagi Grimberg
2020-08-18 20:58 ` Sagi Grimberg
2020-08-19 7:15 ` Engel, Amit
2020-08-19 14:29 ` Engel, Amit
2020-08-19 15:24 ` Sagi Grimberg
2020-08-19 16:04 ` Engel, Amit
2020-09-13 15:18 ` Engel, Amit
2020-09-14 23:53 ` Sagi Grimberg
2020-09-15 6:43 ` Christoph Hellwig
2020-09-15 7:00 ` Engel, Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818162731.GC27196@lst.de \
--to=hch@lst.de \
--cc=amit.engel@dell.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox