From: Keith Busch <kbusch@kernel.org>
To: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de
Cc: Keith Busch <kbusch@kernel.org>
Subject: [PATCHv3] nvme: skip noiob for zoned devices
Date: Tue, 18 Aug 2020 09:29:41 -0700 [thread overview]
Message-ID: <20200818162941.2674340-1-kbusch@kernel.org> (raw)
Zoned block devices reuse the chunk_sectors queue limit to define zone
boundaries. If a such a device happens to also report an optimal
boundary, log a warning of the conflicting attributes and do not use
that to define the chunk_sectors as that may intermittently interfere
with io splitting and zone size queries.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
v2 -> v3:
Emit a warning on the initial validation if a zoned device reports an
optimal boundary.
drivers/nvme/host/core.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 88cff309d8e4..10cf40d2cfef 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2075,8 +2075,13 @@ static int __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id)
}
}
- if (iob)
- blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+ if (iob) {
+ if (!blk_queue_is_zoned(disk->queue))
+ blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob));
+ else if (!(disk->flags & GENHD_FL_UP))
+ pr_warn("%s: zone namespace has unused IO boundary:%u\n",
+ disk->disk_name, iob);
+ }
nvme_update_disk_info(disk, ns, id);
#ifdef CONFIG_NVME_MULTIPATH
if (ns->head->disk) {
--
2.24.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2020-08-18 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 16:29 Keith Busch [this message]
2020-08-18 17:25 ` [PATCHv3] nvme: skip noiob for zoned devices Christoph Hellwig
2020-08-18 17:50 ` Keith Busch
2020-08-18 18:02 ` Christoph Hellwig
2020-08-18 19:10 ` Sagi Grimberg
2020-08-18 19:20 ` Christoph Hellwig
2020-08-18 19:32 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818162941.2674340-1-kbusch@kernel.org \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox