From: Christoph Hellwig <hch@lst.de>
To: Chao Leng <lengchao@huawei.com>
Cc: Keith Busch <kbusch@kernel.org>,
Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 4/4] nvme: redirect commands on dying queue
Date: Wed, 19 Aug 2020 12:50:38 +0200 [thread overview]
Message-ID: <20200819105038.GB3153@lst.de> (raw)
In-Reply-To: <4eeafb53-ad1f-a123-ad73-f996970a6f1e@huawei.com>
On Wed, Aug 19, 2020 at 06:01:46PM +0800, Chao Leng wrote:
> Do not use blk_noretry_request. The local retry mechanism, which is
> defined by nvme protocol, is conflicted with REQ_FAILFAST_TRANSPORT.
> blk_noretry_request is not a good choice for nvme, even for SCSI,
> this is not a good choice too, so SCSI does not use this MACRO.
> We can seperate REQ_FAILFAST_TRANSPORT with other FAILFAST flag.
> For REQ_FAILFAST_TRANSPORT, do local retry for non path error.
> For other FAILFAST flag, complete request with error code immediately.
As said before - please prepare a series removing blk_noretry_request,
and fixing up any lose ends, with a good explanation of what in-tree
supported use case this fixes for you. Out of tree modules are
completely unsupported, as is ANA with dm-multipath.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-19 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 7:11 nvme completion handling refactor and fix v3 Christoph Hellwig
2020-08-18 7:11 ` [PATCH 1/4] nvme: rename and document nvme_end_request Christoph Hellwig
2020-08-18 7:11 ` [PATCH 2/4] nvme: refactor command completion Christoph Hellwig
2020-08-18 7:11 ` [PATCH 3/4] nvme: just check the status code type in nvme_is_path_error Christoph Hellwig
2020-08-19 21:50 ` Chaitanya Kulkarni
2020-08-18 7:11 ` [PATCH 4/4] nvme: redirect commands on dying queue Christoph Hellwig
2020-08-19 10:01 ` Chao Leng
2020-08-19 10:50 ` Christoph Hellwig [this message]
2020-08-18 19:31 ` nvme completion handling refactor and fix v3 Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2020-08-17 8:15 nvme completion handling refactor and fix v2 Christoph Hellwig
2020-08-17 8:15 ` [PATCH 4/4] nvme: redirect commands on dying queue Christoph Hellwig
2020-08-17 15:23 ` Mike Snitzer
2020-08-18 6:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819105038.GB3153@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).