From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH] nvme: fix controller instance leak
Date: Thu, 27 Aug 2020 08:40:21 +0200 [thread overview]
Message-ID: <20200827064021.GA4757@lst.de> (raw)
In-Reply-To: <20200826175304.2151626-1-kbusch@kernel.org>
On Wed, Aug 26, 2020 at 10:53:04AM -0700, Keith Busch wrote:
> If the driver has to unbind from the controller for an early failure
> before the subsystem has been set up, there won't be a subsystem holding
> the controller's instance, so the controller needs to free its own
> instance in this case.
>
> Fixes: 733e4b69d508d ("nvme: Assign subsys instance from first ctrl")
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-08-27 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 17:53 [PATCH] nvme: fix controller instance leak Keith Busch
2020-08-26 18:10 ` Chaitanya Kulkarni
2020-08-27 6:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827064021.GA4757@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox