Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: kbusch@kernel.org, logang@deltatee.com, hch@lst.de,
	linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH V2 04/12] nvmet: use consistent type for op_flag
Date: Thu, 3 Sep 2020 18:20:17 +0200	[thread overview]
Message-ID: <20200903162017.GC25423@lst.de> (raw)
In-Reply-To: <20200831222707.35611-5-chaitanya.kulkarni@wdc.com>

On Mon, Aug 31, 2020 at 03:26:59PM -0700, Chaitanya Kulkarni wrote:
> In function nvmet_passthru_map_sg() we set the bio->bi_opf ored with
> req_op and op_flags set based on the NVMe cmd. The variable bio->bi_opf
> is declared as unsigned int use same type for op_flag.
> 
> Also, adjust the order according to new length.
> 
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> Reviewed By: Logan Gunthorpe <logang@deltatee.com>

Actually all the op_flags used here are bogus and have no meaning for
passthrough commands.  So the right fix is to remove op_flags entirely.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-09-03 16:20 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 22:26 [PATCH V2 00/12] nvmet: passthru fixes and improvements Chaitanya Kulkarni
2020-08-31 22:26 ` [PATCH V2 01/12] nvme-core: annotate nvme_alloc_request() Chaitanya Kulkarni
2020-09-01  1:56   ` Baolin Wang
2020-09-01 17:21     ` Sagi Grimberg
2020-09-01 21:16       ` Chaitanya Kulkarni
2020-09-02  3:28       ` Chaitanya Kulkarni
2020-09-02 22:02       ` Chaitanya Kulkarni
2020-09-03 16:17   ` Christoph Hellwig
2020-09-03 19:40     ` Chaitanya Kulkarni
2020-09-08  8:57       ` Christoph Hellwig
2020-08-31 22:26 ` [PATCH V2 02/12] nvmet: for pt I/O commands use likely for ns check Chaitanya Kulkarni
2020-09-03 16:18   ` Christoph Hellwig
2020-09-03 18:21     ` Chaitanya Kulkarni
2020-08-31 22:26 ` [PATCH V2 03/12] nvmet: use consistent type with id->nlbaf Chaitanya Kulkarni
2020-09-01 15:55   ` Keith Busch
2020-09-01 21:17     ` Chaitanya Kulkarni
2020-09-01 21:31       ` Logan Gunthorpe
2020-09-01 22:03       ` Keith Busch
2020-08-31 22:26 ` [PATCH V2 04/12] nvmet: use consistent type for op_flag Chaitanya Kulkarni
2020-09-03 16:20   ` Christoph Hellwig [this message]
2020-09-03 18:35     ` Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 05/12] nvmet: use unlikely for uncommon commands Chaitanya Kulkarni
2020-09-03 16:20   ` Christoph Hellwig
2020-09-03 18:37     ` Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 06/12] nvmet: remove op_flags for write commands Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 07/12] nvmet: decouple nvme_ctrl_get_by_path() Chaitanya Kulkarni
2020-09-01 17:00   ` Logan Gunthorpe
2020-08-31 22:27 ` [PATCH V2 08/12] nvmet: move get/put ctrl into dev open/release Chaitanya Kulkarni
2020-09-01 17:02   ` Logan Gunthorpe
2020-09-01 17:18     ` Sagi Grimberg
2020-09-02  0:31       ` Chaitanya Kulkarni
2020-09-03 16:21       ` Christoph Hellwig
2020-09-03 18:22         ` Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 09/12] nvmet: fix nvme module ref count Oops Chaitanya Kulkarni
2020-09-01 17:23   ` Logan Gunthorpe
2020-08-31 22:27 ` [PATCH V2 10/12] block: move blk_rq_bio_prep() to linux/blk-mq.h Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 11/12] nvmet: use minimized version of blk_rq_append_bio Chaitanya Kulkarni
2020-09-03 16:23   ` Christoph Hellwig
2020-09-03 18:23     ` Chaitanya Kulkarni
2020-08-31 22:27 ` [PATCH V2 12/12] nvmet: use inline bio for passthru fast path Chaitanya Kulkarni
2020-09-01 17:29   ` Logan Gunthorpe
2020-09-02  0:39     ` Chaitanya Kulkarni
2020-09-02 15:41       ` Logan Gunthorpe
2020-09-02 21:04         ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200903162017.GC25423@lst.de \
    --to=hch@lst.de \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=logang@deltatee.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox