From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org, hch@lst.de
Subject: Re: [PATCH] nvme: translate zns errors to blk_status_t
Date: Thu, 10 Sep 2020 07:26:43 +0200 [thread overview]
Message-ID: <20200910052643.GA18283@lst.de> (raw)
In-Reply-To: <20200909203324.3356679-1-kbusch@kernel.org>
On Wed, Sep 09, 2020 at 01:33:24PM -0700, Keith Busch wrote:
> EBUSY is the appropriate errno for commands that complete with zone
> resource errors.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> drivers/nvme/host/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index ea1fa41fbba8..aff556837115 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -249,6 +249,9 @@ static blk_status_t nvme_error_status(u16 status)
> return BLK_STS_NEXUS;
> case NVME_SC_HOST_PATH_ERROR:
> return BLK_STS_TRANSPORT;
> + case NVME_SC_ZONE_TOO_MANY_ACTIVE:
> + case NVME_SC_ZONE_TOO_MANY_OPEN:
> + return BLK_STS_DEV_RESOURCE;
I'm not sure this is the best idea, we probably need specific error codes
if we want file systems to be aware of the limit.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-09-10 5:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 20:33 [PATCH] nvme: translate zns errors to blk_status_t Keith Busch
2020-09-09 20:52 ` Sagi Grimberg
2020-09-10 0:44 ` Damien Le Moal
2020-09-10 5:26 ` Christoph Hellwig [this message]
2020-09-10 14:45 ` Keith Busch
2020-09-10 22:25 ` Damien Le Moal
2020-09-11 6:10 ` Christoph Hellwig
2020-09-11 9:35 ` Damien Le Moal
2020-09-11 18:08 ` Keith Busch
2020-09-12 6:41 ` Christoph Hellwig
2020-09-14 19:44 ` Keith Busch
2020-09-14 23:25 ` Damien Le Moal
2020-09-15 2:55 ` Keith Busch
2020-09-15 2:57 ` Damien Le Moal
2020-09-15 6:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910052643.GA18283@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox