From: Christoph Hellwig <hch@lst.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] nvme-pci: Move enumeration by class to be last in the table
Date: Tue, 15 Sep 2020 07:50:56 +0200 [thread overview]
Message-ID: <20200915055056.GA18367@lst.de> (raw)
In-Reply-To: <20200914153322.GK3956970@smile.fi.intel.com>
On Mon, Sep 14, 2020 at 06:33:22PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 18, 2020 at 11:35:30AM +0300, Andy Shevchenko wrote:
> > It's unusual that we have enumeration by class in the middle of the table.
> > It might potentially be problematic in the future if we add another entry
> > after it.
> >
> > So, move class matching entry to be the last in the ID table.
>
> Is it good enough?
Yes. This is in my for-5.10 queue, which just hasn't been pushed out
yet.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-09-15 5:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 8:35 [PATCH v2] nvme-pci: Move enumeration by class to be last in the table Andy Shevchenko
2020-09-14 15:33 ` Andy Shevchenko
2020-09-15 5:50 ` Christoph Hellwig [this message]
2020-09-14 19:37 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915055056.GA18367@lst.de \
--to=hch@lst.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@fb.com \
--cc=benh@kernel.crashing.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox