From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: kbusch@kernel.org, hch@lst.de, linux-nvme@lists.infradead.org,
sagi@grimberg.me
Subject: Re: [PATCH V3 5/7] nvmet: add passthru admin timeout value attr
Date: Wed, 16 Sep 2020 09:12:21 +0200 [thread overview]
Message-ID: <20200916071221.GB9592@lst.de> (raw)
In-Reply-To: <20200915215118.3934-6-chaitanya.kulkarni@wdc.com>
On Tue, Sep 15, 2020 at 02:51:16PM -0700, Chaitanya Kulkarni wrote:
> NVMeOF controller in the passsthru mode is capable of handling wide set
> of admin commands including Vender unique passhtru admin comands (VUAC).
VUAC sounds like someone is throwing up and certainly is not NVMe
terminology. I also don't think we should care about stange verndor
specific commands. If we want to communicate command timeout we need
to add them to the command supported and effects log, similar to what
SCSI does in REPORT SUPPORTED OPERATION CODES.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-09-16 7:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 21:51 [PATCH V3 0/7] nvme-core: timeout related fixes and cleanup Chaitanya Kulkarni
2020-09-15 21:51 ` [PATCH V3 1/7] nvme-core: use I/O timeout in submit sync cmd Chaitanya Kulkarni
2020-09-16 7:09 ` Christoph Hellwig
2020-09-16 20:46 ` Chaitanya Kulkarni
2020-09-15 21:51 ` [PATCH V3 2/7] nvme-core: use I/O timeout in nvme_submit_user_cmd Chaitanya Kulkarni
2020-09-15 21:51 ` [PATCH V3 3/7] lightnvm: use I/O timeout in nvm submit user cmd Chaitanya Kulkarni
2020-09-15 21:51 ` [PATCH V3 4/7] nvmet: set default timeout for passthru requests Chaitanya Kulkarni
2020-09-16 20:57 ` Keith Busch
2020-09-16 21:01 ` Chaitanya Kulkarni
2020-09-15 21:51 ` [PATCH V3 5/7] nvmet: add passthru admin timeout value attr Chaitanya Kulkarni
2020-09-16 7:12 ` Christoph Hellwig [this message]
2020-09-16 22:35 ` Chaitanya Kulkarni
2020-09-15 21:51 ` [PATCH V3 6/7] nvmet: add passthru io " Chaitanya Kulkarni
2020-09-15 21:51 ` [PATCH V3 7/7] nvme: use consistent macro name for timeout Chaitanya Kulkarni
2020-09-16 7:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916071221.GB9592@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox