Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Tong Zhang <ztong0001@gmail.com>,
	sagi@grimberg.me, linux-nvme@lists.infradead.org, hch@lst.de
Subject: Re: [PATCH] nvme: return errors for hwmon init
Date: Thu, 17 Sep 2020 17:52:37 +0200	[thread overview]
Message-ID: <20200917155237.GA2441@lst.de> (raw)
In-Reply-To: <20200917155025.3795801-1-kbusch@kernel.org>

On Thu, Sep 17, 2020 at 08:50:25AM -0700, Keith Busch wrote:
> Initializing the nvme hwmon retrieves a log from the controller. If the
> controller is broken, we need to return the appropriate error so that
> subsequent initialization doesn't attempt to continue.
> 
> Reported-by: Tong Zhang <ztong0001@gmail.com>
> Signed-off-by: Keith Busch <kbusch@kernel.org>

Looks good to me.  I'm about to send a PR to Jens later today,
but I plan to pick this up for 5.9 after that.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-09-17 15:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 15:50 [PATCH] nvme: return errors for hwmon init Keith Busch
2020-09-17 15:52 ` Christoph Hellwig [this message]
2020-09-17 16:47   ` Tong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917155237.GA2441@lst.de \
    --to=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=ztong0001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox