From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E0D2C388F9 for ; Tue, 27 Oct 2020 08:04:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3983207BB for ; Tue, 27 Oct 2020 08:04:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TJnfWQPZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3983207BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=32jGpFZfj4aIowj5sTWJCwNdZkkXEWLM+MUTdRwavBw=; b=TJnfWQPZ1szZxJFKwxM+7gc2d /vhUPOocY6pVNpMSfjVv9/eLx7cm8qNEmsGxB+b6GoZOjX/ub+1NrpDr9q9/D1+4CebYQpNPbqQrb +ezqyWu+E4dXe5u5kHHduIp8wM/Ul9Dgfkt7VIH37vKURftYMcTKEu1H4HQyDVbT5Zp0/l+tQhdGM N8sfwlGa5woHo+PFykh9U6jxINT1EPyf0jvnTK2FCK9hqGOOXO8MSrl6uZgOe8FVFkU/mEeIaLKNz fIX+YKcleOkGNaLLlyYm0ZYc3Q1tEv+WzfH5H6MsjLlIGxSvHy5VyxwW3JyBWwWycL/z+VqaIsd0G D5EIOEx6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXJy9-0007Px-5E; Tue, 27 Oct 2020 08:04:37 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXJy4-0007PE-PM for linux-nvme@lists.infradead.org; Tue, 27 Oct 2020 08:04:33 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A078268AFE; Tue, 27 Oct 2020 09:04:29 +0100 (CET) Date: Tue, 27 Oct 2020 09:04:29 +0100 From: Christoph Hellwig To: Jason Gunthorpe Subject: Re: [PATCH] RDMA: Add rdma_connect_locked() Message-ID: <20201027080429.GA22725@lst.de> References: <0-v1-75e124dbad74+b05-rdma_connect_locking_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0-v1-75e124dbad74+b05-rdma_connect_locking_jgg@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_040432_967104_CB180AF3 X-CRM114-Status: UNSURE ( 7.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Gurtovoy , rds-devel@oss.oracle.com, Sagi Grimberg , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Santosh Shilimkar , Guoqing Jiang , linux-nvme@lists.infradead.org, Doug Ledford , Danil Kipnis , Keith Busch , Jack Wang , Leon Romanovsky , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > +int rdma_connect_locked(struct rdma_cm_id *id, struct rdma_conn_param *conn_param) This adds an overly long line. > +int rdma_connect_locked(struct rdma_cm_id *id, struct rdma_conn_param *conn_param); Same here. Otherwise looks good except for the nvme merge error pointed out by Chao Leng. Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme