From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3233C2D0A3 for ; Tue, 3 Nov 2020 18:24:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 505B7206D5 for ; Tue, 3 Nov 2020 18:24:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OSjduBmD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 505B7206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x3G8bhTKNrHC9J3OAGbYQ6cVSYfKynU6EJvHICpImG4=; b=OSjduBmDAi6VhorRayUBbL85Z IRFMnmUKYJfnxkniR6h2sxDj89rLl6yQvqZmQv0cWwm9djb4HKt6Sj4ikr6D5RAAd0MEHz6QxVgFJ WXu0cQrGPzn5138xOvxcZ8PpILiIkpC7g2Fbj5j6Lbv4E7o+Re9HLDhn8pgVIl2IXEyOkF2sduDvH s5mkbL/ZWAbyS2b70i3oCW6gPuj1jLpsp5FXBqCHaDH2W/n+BC8p9djKdCMTLYmM0jG+KgTo08e1Q vyTqr8ngOdtrdYarWd6uV/auIWK74FND17pFS6nOE75getqLABP/FiRc96hc+4dMQfBUu5edbp23U QdmsN6Jfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ka0zE-00045I-38; Tue, 03 Nov 2020 18:24:52 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ka0z9-00043N-V3 for linux-nvme@lists.infradead.org; Tue, 03 Nov 2020 18:24:49 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 845016736F; Tue, 3 Nov 2020 19:24:44 +0100 (CET) Date: Tue, 3 Nov 2020 19:24:44 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Subject: Re: [PATCH V3 2/6] nvme-core: split nvme_alloc_request() Message-ID: <20201103182444.GA23300@lst.de> References: <20201022010234.8304-1-chaitanya.kulkarni@wdc.com> <20201022010234.8304-3-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201022010234.8304-3-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_132448_141922_BE63F42C X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, kbusch@kernel.org, logang@deltatee.com, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 21, 2020 at 06:02:30PM -0700, Chaitanya Kulkarni wrote: > +static inline unsigned int nvme_req_op(struct nvme_command *cmd) > +{ > + return nvme_is_write(cmd) ? REQ_OP_DRV_OUT : REQ_OP_DRV_IN; > +} Why is this added here while nvme_init_req_from_cmd is added in a prep patch? I'm actually fine either way, but doing it differnetly for the different helpers is a little inconsistent. > + > +struct request *nvme_alloc_request_qid_any(struct request_queue *q, > + struct nvme_command *cmd, blk_mq_req_flags_t flags) I'd call this just nvme_alloc_request to keep the short name for the normal use case. > + struct request *req; > + > + req = blk_mq_alloc_request(q, nvme_req_op(cmd), flags); > + if (unlikely(IS_ERR(req))) > + return req; > + > + nvme_init_req_from_cmd(req, cmd); > + return req; Could be simplified to: req = blk_mq_alloc_request(q, nvme_req_op(cmd), flags); if (!IS_ERR(req)) nvme_init_req_from_cmd(req, cmd); return req; Note that IS_ERR already contains an embedded unlikely(). > +static struct request *nvme_alloc_request_qid(struct request_queue *q, > struct nvme_command *cmd, blk_mq_req_flags_t flags, int qid) > { > struct request *req; > > + req = blk_mq_alloc_request_hctx(q, nvme_req_op(cmd), flags, > + qid ? qid - 1 : 0); > if (IS_ERR(req)) > return req; > > nvme_init_req_from_cmd(req, cmd); > return req; Same here. > } > -EXPORT_SYMBOL_GPL(nvme_alloc_request); I think nvme_alloc_request_qid needs to be exported as well. FYI, this also doesn't apply to the current nvme-5.10 tree any more. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme