From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: kbusch@kernel.org, linux-nvme@lists.infradead.org,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
hch@lst.de
Subject: Re: [PATCH V6 5/5] nvme: centralize setting req end_io_data
Date: Thu, 5 Nov 2020 08:28:56 +0100 [thread overview]
Message-ID: <20201105072856.GA4540@lst.de> (raw)
In-Reply-To: <66b805e8-9efe-8f47-b10a-1a8dd6505720@grimberg.me>
On Wed, Nov 04, 2020 at 02:17:05PM -0800, Sagi Grimberg wrote:
>> The host side code allocates the request in several places using
>> nvme_alloc_request() and initialises the allocated request->end_io_data,
>> which repeats the code and will have duplicate code in the future.
>>
>> Add an end_io_data request parameter which initializes the block
>> layer request in nvme_alloc_request(), update the respective callers
>> and remove the duplicate code.
>
> There are less callers that actually put something there so not sure
> if this is an improvement.. The alloc signature is getting kinda bloated
> now...
Yes, I don't really see the point - the request is available to the
caller, so they can trivially assign it.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-11-05 7:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 20:37 [PATCH V6 0/5] nvme-core: timeout related fixes and cleanup Chaitanya Kulkarni
2020-11-04 20:37 ` [PATCH V6 1/5] nvme: centralize setting req timeout Chaitanya Kulkarni
2020-11-04 22:10 ` Sagi Grimberg
2020-11-05 7:31 ` Christoph Hellwig
2020-11-04 20:37 ` [PATCH V6 2/5] nvmet: add passthru admin timeout value attr Chaitanya Kulkarni
2020-11-04 22:13 ` Sagi Grimberg
[not found] ` <BYAPR04MB49655CAAD9809FFC21D5418686EE0@BYAPR04MB4965.namprd04.prod.outlook.com>
2020-11-05 7:32 ` hch
2020-11-05 7:33 ` Christoph Hellwig
2020-11-04 20:37 ` [PATCH V6 3/5] nvmet: add passthru io " Chaitanya Kulkarni
2020-11-04 22:13 ` Sagi Grimberg
2020-11-04 20:37 ` [PATCH V6 4/5] nvme: use consistent macro name for timeout Chaitanya Kulkarni
2020-11-04 22:14 ` Sagi Grimberg
2020-11-04 20:37 ` [PATCH V6 5/5] nvme: centralize setting req end_io_data Chaitanya Kulkarni
2020-11-04 22:17 ` Sagi Grimberg
2020-11-05 7:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105072856.GA4540@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox