Re: [PATCH 22/24] md: remove a spurious call to revalidate_disk_size in update_size

Song Liu
2020-11-07T00:40:06Z

On Fri, Nov 6, 2020 at 11:04 AM Christoph Hellwig <hch@lst.de> wrote:
>
> None of the ->resize methods updates the disk size, so calling
> revalidate_disk_size here won't do anything.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Song Liu <song@kernel.org>

> ---
> drivers/md/md-cluster.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
> index 87442dc59f6ca3..35e2690c1803dd 100644
> --- a/drivers/md/md-cluster.c
> +++ b/drivers/md/md-cluster.c
> @@ -1299,8 +1299,6 @@ static void update_size(struct mddev *mddev, sector_t old_dev_sectors)
> } else {
> /* revert to previous sectors */
> ret = mddev->pers->resize(mddev, old_dev_sectors);
> - if (!ret)
> - revalidate_disk_size(mddev->gendisk, true);
> ret = __sendmsg(cinfo, &cmsg);
> if (ret)
> pr_err("%s:%d: failed to send METADATA_UPDATED msg\n",
> --
> 2.28.0
>