Re: [PATCH 18/24] rnbd: use set_capacity_and_notify

Jinpu Wang
2020-11-09T06:57:05Z

On Fri, Nov 6, 2020 at 8:04 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Use set_capacity_and_notify to set the size of both the disk and block
> device. This also gets the uevent notifications for the resize for free.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks, Christoph!
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
> drivers/block/rnbd/rnbd-clt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
> index 8b2411ccbda97c..bb13d7dd195a08 100644
> --- a/drivers/block/rnbd/rnbd-clt.c
> +++ b/drivers/block/rnbd/rnbd-clt.c
> @@ -100,8 +100,7 @@ static int rnbd_clt_change_capacity(struct rnbd_clt_dev *dev,
> rnbd_clt_info(dev, "Device size changed from %zu to %zu sectors\n",
> dev->nsectors, new_nsectors);
> dev->nsectors = new_nsectors;
> - set_capacity(dev->gd, dev->nsectors);
> - revalidate_disk_size(dev->gd, true);
> + set_capacity_and_notify(dev->gd, dev->nsectors);
> return 0;
> }
>
> --
> 2.28.0
>