Re: [PATCH 17/24] rbd: use set_capacity_and_notify

Ilya Dryomov
2020-11-09T13:52:16Z

On Fri, Nov 6, 2020 at 8:04 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Use set_capacity_and_notify to set the size of both the disk and block
> device. This also gets the uevent notifications for the resize for free.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/block/rbd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index f84128abade319..b7a194ffda55b4 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -4920,8 +4920,7 @@ static void rbd_dev_update_size(struct rbd_device *rbd_dev)
> !test_bit(RBD_DEV_FLAG_REMOVING, &rbd_dev->flags)) {
> size = (sector_t)rbd_dev->mapping.size / SECTOR_SIZE;
> dout("setting size to %llu sectors", (unsigned long long)size);
> - set_capacity(rbd_dev->disk, size);
> - revalidate_disk_size(rbd_dev->disk, true);
> + set_capacity_and_notify(rbd_dev->disk, size);
> }
> }
>
> --
> 2.28.0
>

Acked-by: Ilya Dryomov <idryomov@gmail.com>

Thanks,

Ilya