From: Greg KH <gregkh@linuxfoundation.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <keith.busch@intel.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: Boot as soon as the boot controller has been probed
Date: Sun, 8 Nov 2020 20:18:31 +0100 [thread overview]
Message-ID: <20201108191831.GA601832@kroah.com> (raw)
In-Reply-To: <da5be7f4-fa7e-3896-fd1e-8d2c0d80565a@grimberg.me>
On Sun, Nov 08, 2020 at 11:13:11AM -0800, Sagi Grimberg wrote:
>
> > The following two issues have been introduced by commit 1811977568e0
> > ("nvme/pci: Use async_schedule for initial reset work"):
> > - The boot process waits until all NVMe controllers have been probed
> > instead of only waiting until the boot controller has been probed.
> > This slows down the boot process.
> > - Some of the controller probing work happens asynchronously without
> > the device core being aware of this.
> >
> > Hence this patch that makes all probing work happen from nvme_probe()
> > and that tells the device core to probe multiple NVMe controllers
> > concurrently by setting PROBE_PREFER_ASYNCHRONOUS.
>
> This would make the controller instance inconsistent across reboots
> which is annoying for some users.
Then they should use persistent device names, as that is what they are
there for :)
Bus naming persistance is not a thing, we have BIOSes that love to
renumber PCI busses every other boot quite frequently. If you have such
whacky hardware, fix this in userspace which is where it has been done
for a while now.
thanks,
greg k-h
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-11-08 19:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 4:09 [PATCH] nvme: Boot as soon as the boot controller has been probed Bart Van Assche
2020-11-08 8:24 ` Greg KH
2020-11-08 22:31 ` Keith Busch
2020-11-08 23:35 ` Bart Van Assche
2020-11-09 2:35 ` Keith Busch
2020-11-09 4:00 ` Bart Van Assche
2020-11-09 15:05 ` Keith Busch
2020-11-10 2:51 ` Bart Van Assche
2020-11-10 3:12 ` Keith Busch
2020-11-08 19:13 ` Sagi Grimberg
2020-11-08 19:18 ` Greg KH [this message]
2020-11-08 23:00 ` Bart Van Assche
2020-11-09 3:04 ` Keith Busch
2020-11-11 19:19 ` Keith Busch
2020-11-12 4:26 ` Bart Van Assche
2020-11-12 14:20 ` Keith Busch
2020-11-19 3:08 ` Bart Van Assche
2020-11-19 20:18 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108191831.GA601832@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mpatocka@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox