From: Christoph Hellwig <hch@lst.de>
To: Martin George <martinus.gpy@gmail.com>
Cc: kbusch@kernel.org, Martin George <marting@netapp.com>,
hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group
Date: Wed, 18 Nov 2020 17:24:15 +0100 [thread overview]
Message-ID: <20201118162415.GA16753@lst.de> (raw)
In-Reply-To: <20201118114859.7985-1-marting@netapp.com>
On Wed, Nov 18, 2020 at 05:18:59PM +0530, Martin George wrote:
> From: Martin George <marting@netapp.com>
>
> The current nvme rescan triggered in response to a NS Attr Changed
> AEN, fails to add a namespace if belonging to a new ANA group. This
> is because ana_log_buf->ngrps is not updated in nvme_parse_ana_log(),
> due to which it is unable to locate the new ANA group's descriptor,
> eventually resulting in the failure to add the namespace during the
> rescan. Fix this by reading the ANA log page as part of ana_work so
> that ngrps gets updated, prior to invoking nvme_queue_scan().
How can the namespace reference an ANA group that we haven't been
notified about using the NVME_AEN_CFG_ANA_CHANGE AEN before?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next parent reply other threads:[~2020-11-18 16:24 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201118114859.7985-1-marting@netapp.com>
2020-11-18 16:24 ` Christoph Hellwig [this message]
2020-11-18 20:09 ` [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group George, Martin
2020-11-20 9:44 ` hch
2020-11-23 14:35 ` Meneghini, John
2020-11-23 15:27 ` Knight, Frederick
2020-11-23 15:54 ` Meneghini, John
2020-12-07 15:25 ` hch
2020-12-08 15:21 ` Knight, Frederick
2020-12-08 17:40 ` Keith Busch
2020-12-08 18:15 ` Knight, Frederick
2020-12-08 18:34 ` Keith Busch
2020-12-08 19:13 ` Knight, Frederick
2020-12-08 21:46 ` Keith Busch
2020-12-09 0:07 ` Knight, Frederick
2020-12-09 0:20 ` Keith Busch
2020-12-09 7:26 ` Hannes Reinecke
2020-12-09 0:13 ` Knight, Frederick
2020-12-09 7:28 ` hch
2020-12-09 15:20 ` Knight, Frederick
2020-12-09 15:53 ` Keith Busch
2020-12-09 16:02 ` Hannes Reinecke
2020-12-09 16:19 ` Keith Busch
2020-12-09 17:04 ` Hannes Reinecke
2020-12-09 17:39 ` Keith Busch
2020-12-09 17:47 ` hch
2020-12-09 20:58 ` Knight, Frederick
2020-12-09 21:34 ` Keith Busch
2020-12-10 8:51 ` hch
2020-12-10 9:13 ` Hannes Reinecke
2020-12-10 13:34 ` Keith Busch
2021-01-14 3:09 ` Sagi Grimberg
2021-01-14 22:59 ` Knight, Frederick
2021-01-14 23:16 ` Keith Busch
2021-01-15 7:15 ` Hannes Reinecke
2020-11-23 17:36 ` Keith Busch
2020-11-23 19:16 ` Sagi Grimberg
2020-11-23 19:29 ` George, Martin
2020-11-23 19:43 ` Keith Busch
2020-11-26 16:16 ` George, Martin
2020-12-04 14:40 ` Hannes Reinecke
2020-11-18 16:51 ` Sagi Grimberg
2020-11-18 20:16 ` George, Martin
2020-11-20 9:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118162415.GA16753@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marting@netapp.com \
--cc=martinus.gpy@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).