From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F24C2D0E4 for ; Wed, 25 Nov 2020 01:32:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4606206D5 for ; Wed, 25 Nov 2020 01:32:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AYr2diPG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dbaGlpal" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4606206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P35919Qu4NmjQlI0Ph4UTzxybtIB6El+CEDVHfzZ0CQ=; b=AYr2diPGqPajOUJjBZlK+yXXO sQfig4NGxIWl/gPjKws0dXEFVggJQmw+lzta1SVuTPZqEKBf8wRJy+4aB8gbXqcR550ajijslrf/Z H1xmXYRi0/mTUYnz0lSlhDcdKWKjf8+B53vErVy2kg8o1zSePTulNIeTJE2Ye9ibir2rkry6Btl76 AR9Q5Gq8k2oF/9gdhD1oOeaTLgvfDm1r1pWhKpgUI2EaFpCxMs2hRX1QRVpBJaS51l9yy/hHUmQWY a3IVUdBwp25gDqp+Mzu9cJRwj27OTvH907ujvgX8GP6PZ9rXXE+WjX8VcJzRF/DkMqbII1PWcozSg gFjtN2lhA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khjfQ-0007b7-M5; Wed, 25 Nov 2020 01:32:20 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khjfM-0007an-To for linux-nvme@lists.infradead.org; Wed, 25 Nov 2020 01:32:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606267934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=33B9Bc8AL4A8pd4lTa4MRYTlvTr/1KxG8KKDCk2V4gA=; b=dbaGlpalG1NAx0oj6p9TofV3pxYn8+HUiWsH8YQtRw1zWYpe1zhoC/cKIgjK5HD/5nv5VT IPRwTPqTesn5G6BfPgBOYMz7NrMQ7MPLzftBopqrHm/mdEd7c7PW5X3ditEF28Am0sdDBJ 59c3EHMiIGzDdJ/cKponh3D35/7snNI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-55--xLtkNnqNWeUwypcmPt-PQ-1; Tue, 24 Nov 2020 20:32:06 -0500 X-MC-Unique: -xLtkNnqNWeUwypcmPt-PQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BA73C805F01; Wed, 25 Nov 2020 01:32:04 +0000 (UTC) Received: from T590 (ovpn-12-203.pek2.redhat.com [10.72.12.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74B3E5C1A1; Wed, 25 Nov 2020 01:31:51 +0000 (UTC) Date: Wed, 25 Nov 2020 09:31:47 +0800 From: Ming Lei To: Jens Axboe , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Christoph Hellwig Subject: Re: [PATCH 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning Message-ID: <20201125013147.GA8825@T590> References: <20201112075526.947079-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201112075526.947079-1-ming.lei@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_203217_035450_2D854D62 X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bart Van Assche , Qian Cai , John Garry , Kashyap Desai , Sumit Saxena , Hannes Reinecke Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Nov 12, 2020 at 03:55:23PM +0800, Ming Lei wrote: > Hi, > > Qian reported there is hang during booting when shared host tagset is > introduced on megaraid sas. Sumit reported the whole SCSI probe takes > about ~45min in his test. > > Turns out it is caused by nr_hw_queues increased, especially commit > b3c6a5997541("block: Fix a lockdep complaint triggered by request queue flushing") > adds synchronize_rcu() for each hctx's release handler. > > Address the original lockdep false positive warning by simpler way, then > long scsi probe can be avoided with lockdep enabled. > > Ming Lei (3): > blk-mq: add new API of blk_mq_hctx_set_fq_lock_class > nvme-loop: use blk_mq_hctx_set_fq_lock_class to set loop's lock class > Revert "block: Fix a lockdep complaint triggered by request queue > flushing" > > block/blk-flush.c | 30 +++++++++++++++++++++++++----- > block/blk.h | 1 - > drivers/nvme/target/loop.c | 10 ++++++++++ > include/linux/blk-mq.h | 3 +++ > 4 files changed, 38 insertions(+), 6 deletions(-) > > Cc: Qian Cai > Cc: Sumit Saxena > Cc: John Garry > Cc: Kashyap Desai > Cc: Bart Van Assche > Cc: Hannes Reinecke Hello Jens, Ping... thanks, Ming _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme