From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DBEC433FE for ; Mon, 7 Dec 2020 19:14:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D56FE2342C for ; Mon, 7 Dec 2020 19:14:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D56FE2342C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=javigon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xdR6//8wpIg1goVZhlf0kxi+FPn/7hctGndrH96lFhE=; b=BkMwnErSgzQnUB+2S5x1XQa6z uWQXJD9DiyrhcZZYFmXdftR3WF1nqklHwpWJQCHMjbbTZMiYRDpThdP372LxKIb044L6I5ubOzkIH sClELvL6blBHtaQUe62RU5OqFSCs2YVeRLpC1clO8SsNtVNYFDWLZab6/Ugh7Zkk6RwKpK+sdGImw nxsQHlLH2p98SPVLHOnKpeoA0pAfI0lUaWd6EAWOob01VULO60Z35sQ3JEDh+jkKPXIkXxLyhtkTT Uwy6cnu73lX74UY+l6vh3/KWqKXkwL0imLVEmQWAlpgkaAHZlOd0IZ2w/BeBIRc5PLpc2h1165e7p GWwKsEGLw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmLxx-0007Wg-2e; Mon, 07 Dec 2020 19:14:33 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmLxs-0007W8-Lj for linux-nvme@lists.infradead.org; Mon, 07 Dec 2020 19:14:29 +0000 Received: by mail-ed1-x541.google.com with SMTP id v22so14925466edt.9 for ; Mon, 07 Dec 2020 11:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=javigon-com.20150623.gappssmtp.com; s=20150623; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jmde5DLX9qAtIBMJ/NIdWYTAYpRwSsr9Odz1F7TWunw=; b=lddAqGm3MQoZxuH4PKvKMDzUnTsn3VtxH0cgyRXTomrtszvuHuMHEUxsbPiCkI579U 9fLOvCMZ8FK8gp5Oih+Q9tI2pQ7qYcs31bw6oW4MHEIZ/omzxGJoZGz9nNefzsTaVQHF zZkMg9WyWvthMYZb0F8P5Zv7NnYq/M72blkP/K9mFkUZvM5KWR1VxPsev4AFiaoxqipG Y0G+gRTN/2+zVbsi/oNEKdlwpBZOr2RR4YW9/ufDlvzPIw4leFiqYPUcJvBj/SZ5iQDv JNMs1F1cZ4eKve8lE2wWc37PRmqXPIpt3zBjnZHmHinxyLyexfxe1orLjjF4vD5L7sRt kDDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jmde5DLX9qAtIBMJ/NIdWYTAYpRwSsr9Odz1F7TWunw=; b=DXIpisT+7JGe+uKYYILXuogIACrCglfzMa2b8lcszf2XUZ6UZAt5TiU3m2N99LaRa5 g3MvAZtXVG9DIZ+KYFUjKTRaIQf7BYjIn1cZohQZpTKe78O7zCSQQgEeaVTitMWlYqyD YPoWdT8uDolNpRR47gSRMKuE80vki0NuZki3/vbVuQdtuNqptwCAbCsW/eoPlhikUd23 8dbtWwx4nHmp7bDyicdoEuHreyl+3QIGSXtRBheUCPGc1ng2FlDHAgHEO4/MhRXvnwJo DwC7fEnNjG4PYm9B734MnTEYT/HOyrXSKq9Q8qEsiN6CQfL0QC2SNzQxj0T4AFhyFK5D XIqQ== X-Gm-Message-State: AOAM530Pj1WNHEXddi6tEIGqe3ODgdgEjfVDhpe6nZGAx5Y0yskKBNQo IN33RqSshm6kOb5PZYs4SQlXGQ== X-Google-Smtp-Source: ABdhPJwAxYlw0xJXIJ41PWVh5rYvbijBwYLzNksYRS3VcSJC/SMdkG5LM2Q6gxg67VeNVe1TazaBGA== X-Received: by 2002:a50:fe8d:: with SMTP id d13mr20530601edt.132.1607368465788; Mon, 07 Dec 2020 11:14:25 -0800 (PST) Received: from localhost (5.186.124.214.cgn.fibianet.dk. [5.186.124.214]) by smtp.gmail.com with ESMTPSA id l1sm5898215eje.12.2020.12.07.11.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 11:14:25 -0800 (PST) From: "Javier =?utf-8?B?R29uesOhbGV6?=" X-Google-Original-From: Javier =?utf-8?B?R29uesOhbGV6?= Date: Mon, 7 Dec 2020 20:14:24 +0100 To: Christoph Hellwig Subject: Re: [RFC PATCH v2 0/2] add simple copy support Message-ID: <20201207191424.bzwoonfpxknbbqlc@mpHalley> References: <20201204094659.12732-1-selvakuma.s1@samsung.com> <20201207141123.GC31159@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201207141123.GC31159@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_141428_878757_BF911DDF X-CRM114-Status: GOOD ( 25.63 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, damien.lemoal@wdc.com, SelvaKumar S , sagi@grimberg.me, snitzer@redhat.com, selvajove@gmail.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, dm-devel@redhat.com, Mikulas Patocka , joshi.k@samsung.com, "Martin K. Petersen" , kbusch@kernel.org, linux-scsi@vger.kernel.org, nj.shetty@samsung.com, Bart Van Assche Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 07.12.2020 15:11, Christoph Hellwig wrote: >So, I'm really worried about: > > a) a good use case. GC in f2fs or btrfs seem like good use cases, as > does accelating dm-kcopyd. I agree with Damien that lifting dm-kcopyd > to common code would also be really nice. I'm not 100% sure it should > be a requirement, but it sure would be nice to have > I don't think just adding an ioctl is enough of a use case for complex > kernel infrastructure. We are looking at dm-kcopyd. I would have liked to start with a very specific use case and build from there, but I see Damien's and Keith's point of having a default path. I believe we can add this to the next version. > b) We had a bunch of different attempts at SCSI XCOPY support form IIRC > Martin, Bart and Mikulas. I think we need to pull them into this > discussion, and make sure whatever we do covers the SCSI needs. Agree. We discussed a lot about the scope and agreed that everything outside of the specifics of Simple Copy requires the input from the ones that have worked on XCOPY support in the past. > >On Fri, Dec 04, 2020 at 03:16:57PM +0530, SelvaKumar S wrote: >> This patchset tries to add support for TP4065a ("Simple Copy Command"), >> v2020.05.04 ("Ratified") >> >> The Specification can be found in following link. >> https://nvmexpress.org/wp-content/uploads/NVM-Express-1.4-Ratified-TPs-1.zip >> >> This is an RFC. Looking forward for any feedbacks or other alternate >> designs for plumbing simple copy to IO stack. >> >> Simple copy command is a copy offloading operation and is used to copy >> multiple contiguous ranges (source_ranges) of LBA's to a single destination >> LBA within the device reducing traffic between host and device. >> >> This implementation accepts destination, no of sources and arrays of >> source ranges from application and attach it as payload to the bio and >> submits to the device. >> >> Following limits are added to queue limits and are exposed in sysfs >> to userspace >> - *max_copy_sectors* limits the sum of all source_range length >> - *max_copy_nr_ranges* limits the number of source ranges >> - *max_copy_range_sectors* limit the maximum number of sectors >> that can constitute a single source range. >> >> Changes from v1: >> >> 1. Fix memory leak in __blkdev_issue_copy >> 2. Unmark blk_check_copy inline >> 3. Fix line break in blk_check_copy_eod >> 4. Remove p checks and made code more readable >> 5. Don't use bio_set_op_attrs and remove op and set >> bi_opf directly >> 6. Use struct_size to calculate total_size >> 7. Fix partition remap of copy destination >> 8. Remove mcl,mssrl,msrc from nvme_ns >> 9. Initialize copy queue limits to 0 in nvme_config_copy >> 10. Remove return in QUEUE_FLAG_COPY check >> 11. Remove unused OCFS >> >> SelvaKumar S (2): >> block: add simple copy support >> nvme: add simple copy support >> >> block/blk-core.c | 94 ++++++++++++++++++++++++++--- >> block/blk-lib.c | 123 ++++++++++++++++++++++++++++++++++++++ >> block/blk-merge.c | 2 + >> block/blk-settings.c | 11 ++++ >> block/blk-sysfs.c | 23 +++++++ >> block/blk-zoned.c | 1 + >> block/bounce.c | 1 + >> block/ioctl.c | 43 +++++++++++++ >> drivers/nvme/host/core.c | 87 +++++++++++++++++++++++++++ >> include/linux/bio.h | 1 + >> include/linux/blk_types.h | 15 +++++ >> include/linux/blkdev.h | 15 +++++ >> include/linux/nvme.h | 43 ++++++++++++- >> include/uapi/linux/fs.h | 13 ++++ >> 14 files changed, 461 insertions(+), 11 deletions(-) >> >> -- >> 2.25.1 >---end quoted text--- _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme