From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B45C433FE for ; Tue, 8 Dec 2020 14:04:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79CFF23A22 for ; Tue, 8 Dec 2020 14:04:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79CFF23A22 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0eAI6oeGLyqfAA0dRrjSxVx/6JmDsn7Yl7qc5MyQQJk=; b=XlpO4tdHBfehLdLo5/Wz/imYx 5/fqXsI5RYVOTWMhFN6kW5cwKhJWKC1gEs5Zv9lBVcrCS9iafRP19f3h3QX0jBX7GAhQWPJTe5E8W /P6ILzWnEjFikyoUXiiYG864GtjonhsQGd7aMHcJbhJHDalGlLYNbMRf6U88N/yoFcWT76Q8fNo6l 1QMY+0Svb/bkZB4TpNHabzgibjwJizzlFRQNZwtZuc1Htje/gjm4CA4HfoX6LvlWNo29RNYUks+Ho OpprmdpLUgVjn4UY7H9K2mLGJnc6lNAQHI5/+GarvC9u6VBOF9Z+NA/mq3h0yi7mdSBsSFXiuo6Fg xYH7DKPrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmdaw-0002Kc-9U; Tue, 08 Dec 2020 14:03:58 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmdat-0002Jv-MZ for linux-nvme@lists.infradead.org; Tue, 08 Dec 2020 14:03:56 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 830AC6736F; Tue, 8 Dec 2020 15:03:52 +0100 (CET) Date: Tue, 8 Dec 2020 15:03:52 +0100 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCH] nvme: retrigger ANA log update if group descriptor isn't found Message-ID: <20201208140352.GB2919@lst.de> References: <20201205152901.56665-1-hare@suse.de> <20201207153121.GA3679937@dhcp-10-100-145-180.wdc.com> <20201207153443.GA6236@lst.de> <20201207154650.GB3679937@dhcp-10-100-145-180.wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201207154650.GB3679937@dhcp-10-100-145-180.wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_090355_861059_63EFF640 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Keith Busch , Christoph Hellwig , linux-nvme@lists.infradead.org, Hannes Reinecke Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Dec 07, 2020 at 07:46:50AM -0800, Keith Busch wrote: > > But as I just outlined it just papers over buggy controllers. I really > > don't think we should just silently do that. > > Okay, that's fine with me too. I agree with you on what the correct > event sequence should be, but I just thought this looks like a fairly > harmless work-around. I see three major downsides: (1) it papers over our host side bug where we do not process the different AENs in the order that the controller generated them (2) the code is black magic as there is no indicator why this condition would happen _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme