linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "hch@lst.de" <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: "George, Martin" <Martin.George@netapp.com>,
	Hannes Reinecke <hare@suse.com>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Hannes Reinecke <hare@suse.de>, "hch@lst.de" <hch@lst.de>,
	"Knight, Frederick" <Frederick.Knight@netapp.com>,
	"Meneghini, John" <John.Meneghini@netapp.com>
Subject: Re: [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group
Date: Wed, 9 Dec 2020 18:47:18 +0100	[thread overview]
Message-ID: <20201209174718.GA19512@lst.de> (raw)
In-Reply-To: <20201209173936.GA31971@redsun51.ssa.fujisawa.hgst.com>

On Thu, Dec 10, 2020 at 02:39:36AM +0900, Keith Busch wrote:
> > The use-case I'm trying to describe is that the admin on the storage array
> > is creating a namespace and attaching it to an existing subsystem,
> > completely without interaction from the host. It just so happens that this
> > new namespace has a different ANA group than the existing namespaces in this
> > subsystem.
> > Then the array has to notify the host about this.
> > And the whole discussion is about which AENs this controller/storage array
> > should be sending.
> 
> Fred keeps saying the spec's rules for NVMe's namespace create command
> from section 5.20 allow him to not send events, but it turns out you're
> not even using this command? Why would the spec's defined behavior apply
> to this proprietary use case?

I think we are in an even deeper mess here than I though.

 - one issue is the fact that the exception gets creating vs attaching
   and deleting vs detaching wrong, and that probably is my fault.
 - the other one is the wording should be shall not send the event
   when the creation is ONLY due to the creation of a namespace, that
   is not when a new ANA group shows up (and the way how ANA groups
   are created is out of scope)

So if we do a textual interpretation of the spec, the controller does
not only need to send the ANA AEN for the case we are debatting here,
but also for the case I specifically wanted to exclude.  Sigh.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-12-09 17:47 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201118114859.7985-1-marting@netapp.com>
2020-11-18 16:24 ` [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group Christoph Hellwig
2020-11-18 20:09   ` George, Martin
2020-11-20  9:44     ` hch
2020-11-23 14:35       ` Meneghini, John
2020-11-23 15:27         ` Knight, Frederick
2020-11-23 15:54           ` Meneghini, John
2020-12-07 15:25           ` hch
2020-12-08 15:21             ` Knight, Frederick
2020-12-08 17:40               ` Keith Busch
2020-12-08 18:15                 ` Knight, Frederick
2020-12-08 18:34                   ` Keith Busch
2020-12-08 19:13                     ` Knight, Frederick
2020-12-08 21:46                       ` Keith Busch
2020-12-09  0:07                         ` Knight, Frederick
2020-12-09  0:20                           ` Keith Busch
2020-12-09  7:26                             ` Hannes Reinecke
2020-12-09  0:13                         ` Knight, Frederick
2020-12-09  7:28                           ` hch
2020-12-09 15:20                             ` Knight, Frederick
2020-12-09 15:53                               ` Keith Busch
2020-12-09 16:02                                 ` Hannes Reinecke
2020-12-09 16:19                                   ` Keith Busch
2020-12-09 17:04                                     ` Hannes Reinecke
2020-12-09 17:39                                       ` Keith Busch
2020-12-09 17:47                                         ` hch [this message]
2020-12-09 20:58                                           ` Knight, Frederick
2020-12-09 21:34                                             ` Keith Busch
2020-12-10  8:51                                               ` hch
2020-12-10  9:13                                                 ` Hannes Reinecke
2020-12-10 13:34                                                   ` Keith Busch
2021-01-14  3:09                                                     ` Sagi Grimberg
2021-01-14 22:59                                                       ` Knight, Frederick
2021-01-14 23:16                                                         ` Keith Busch
2021-01-15  7:15                                                         ` Hannes Reinecke
2020-11-23 17:36       ` Keith Busch
2020-11-23 19:16         ` Sagi Grimberg
2020-11-23 19:29           ` George, Martin
2020-11-23 19:43             ` Keith Busch
2020-11-26 16:16               ` George, Martin
2020-12-04 14:40                 ` Hannes Reinecke
2020-11-18 16:51 ` Sagi Grimberg
2020-11-18 20:16   ` George, Martin
2020-11-20  9:46   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209174718.GA19512@lst.de \
    --to=hch@lst.de \
    --cc=Frederick.Knight@netapp.com \
    --cc=John.Meneghini@netapp.com \
    --cc=Martin.George@netapp.com \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).