From: "hch@lst.de" <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: "George, Martin" <Martin.George@netapp.com>,
Hannes Reinecke <hare@suse.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Hannes Reinecke <hare@suse.de>, "hch@lst.de" <hch@lst.de>,
"Knight, Frederick" <Frederick.Knight@netapp.com>,
"Meneghini, John" <John.Meneghini@netapp.com>
Subject: Re: [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group
Date: Thu, 10 Dec 2020 09:51:11 +0100 [thread overview]
Message-ID: <20201210085111.GA15999@lst.de> (raw)
In-Reply-To: <20201209213437.GA3682670@dhcp-10-100-145-180.wdc.com>
On Wed, Dec 09, 2020 at 01:34:37PM -0800, Keith Busch wrote:
> Linux hosts currently want an ANA AEN anytime the host needs to refresh
> the ANA log. That includes any condition that adds groups that didn't
> exist from the host's previous reading.
>
> If the Namespace Attach occurs to an ANA group the host already knows
> about, then you don't need to send an ANA AEN because there's nothing
> new in the log that the host requires. You just need to send the NS
> Notify AEN.
>
> But if a side effect of attaching a namespace results in a new ANA group
> becoming visible to the host, then that group creation is considered a
> separate event, so the host wants both AENs. I believe this is where
> Christoph is trying to steer the interpretation and the text.
Exactly. Although as Hannes pointed out, this language:
If, for an ANA Group, there are no namespaces attached to the
controller processing the command, then no ANA Group Descriptor is
returned for that ANA Group (i.e., an ANA Group Descriptor is returned
only if that ANA Group contains namespaces that are attached to the
controller processing the command.
creates a bit of a chicken an egg problem in that case of a newly
attached namespace that is the first one referencing an ANA group.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-12-10 8:51 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201118114859.7985-1-marting@netapp.com>
2020-11-18 16:24 ` [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group Christoph Hellwig
2020-11-18 20:09 ` George, Martin
2020-11-20 9:44 ` hch
2020-11-23 14:35 ` Meneghini, John
2020-11-23 15:27 ` Knight, Frederick
2020-11-23 15:54 ` Meneghini, John
2020-12-07 15:25 ` hch
2020-12-08 15:21 ` Knight, Frederick
2020-12-08 17:40 ` Keith Busch
2020-12-08 18:15 ` Knight, Frederick
2020-12-08 18:34 ` Keith Busch
2020-12-08 19:13 ` Knight, Frederick
2020-12-08 21:46 ` Keith Busch
2020-12-09 0:07 ` Knight, Frederick
2020-12-09 0:20 ` Keith Busch
2020-12-09 7:26 ` Hannes Reinecke
2020-12-09 0:13 ` Knight, Frederick
2020-12-09 7:28 ` hch
2020-12-09 15:20 ` Knight, Frederick
2020-12-09 15:53 ` Keith Busch
2020-12-09 16:02 ` Hannes Reinecke
2020-12-09 16:19 ` Keith Busch
2020-12-09 17:04 ` Hannes Reinecke
2020-12-09 17:39 ` Keith Busch
2020-12-09 17:47 ` hch
2020-12-09 20:58 ` Knight, Frederick
2020-12-09 21:34 ` Keith Busch
2020-12-10 8:51 ` hch [this message]
2020-12-10 9:13 ` Hannes Reinecke
2020-12-10 13:34 ` Keith Busch
2021-01-14 3:09 ` Sagi Grimberg
2021-01-14 22:59 ` Knight, Frederick
2021-01-14 23:16 ` Keith Busch
2021-01-15 7:15 ` Hannes Reinecke
2020-11-23 17:36 ` Keith Busch
2020-11-23 19:16 ` Sagi Grimberg
2020-11-23 19:29 ` George, Martin
2020-11-23 19:43 ` Keith Busch
2020-11-26 16:16 ` George, Martin
2020-12-04 14:40 ` Hannes Reinecke
2020-11-18 16:51 ` Sagi Grimberg
2020-11-18 20:16 ` George, Martin
2020-11-20 9:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210085111.GA15999@lst.de \
--to=hch@lst.de \
--cc=Frederick.Knight@netapp.com \
--cc=John.Meneghini@netapp.com \
--cc=Martin.George@netapp.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).