From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D03C433E0 for ; Tue, 5 Jan 2021 19:16:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77B7722D58 for ; Tue, 5 Jan 2021 19:16:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77B7722D58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4lcpf7Rts2+ayqltvdHBpULkUFBbIbGJlAakp9cj4WY=; b=B3vhlUk8rcHGIfrFfLQgkYDKv xI9+OchAHqa3BgNDfQug7Vz5xdW9QLen1BXUE3pCUDMmXpg6GZnCjoK5qX52hZa8cmFuswwBVSrti RSl3CGQC0MnzaZBQuteT+XjUW5QBEDFPQl6Cm9gkSjtiqa1mou+41Q+fjullVkwzwfEm9ilQqGQfL 0SSamgKnlb+QoEEbrvM1YKfbT/wPL5AXRtJDkM6bAeFkwSplLCDS4IglUfQVbdy3DYjqILAWsnna1 3HvR+fvr+2vC89NQ3xWGBQB4TtLQ1/z/2pCdUR9fnHoFajJCZDlJ+qYIEgx30z+cTjaxq+rd3xGEB 6qubtShcg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwrp0-0006ic-1k; Tue, 05 Jan 2021 19:16:46 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwrox-0006iG-Ms for linux-nvme@lists.infradead.org; Tue, 05 Jan 2021 19:16:44 +0000 Received: by mail-pf1-x436.google.com with SMTP id c12so288320pfo.10 for ; Tue, 05 Jan 2021 11:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vWNDNO/XfL/ncHE2eKOk0BmDNlW2uHwe3nGMOUQkjSg=; b=qL9igD4xefW/McBb0zKsXnDcsGrq9Yif5tKyBfFA6BpjyRHrPi5vFFi/r3viVAOTab 49Uq6t0dtq4WAEQSA+TXs72nJdz2LUs4qejtcipbOmRYIFCH/7YS2S8ABxtnHzgobznO 3+nD0w2ly7DU3R8bT20xshiavl1o+TM1v+VvTRwhMVzRZROmZztA2xbr5Z/mydULguHK urIWtrMW7uiRT5oDKIOMvF/CSgvaHUq0loCqNhYi4Oiqj/WwLPUmbeM+URR4mpB3YQ6A Vsl/rA8YlXy982aT0gHNniol35+ZF1e9e19Kt+ur/ytRO9Ay6IrxWMTRJAhZ9Sr4eptr d1UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vWNDNO/XfL/ncHE2eKOk0BmDNlW2uHwe3nGMOUQkjSg=; b=KYCunNnlZ3kYeCVhMRV7QHE8fpMheSEaBRf2lgeuNIKCbg5f2xUTyumKzPL0GB/r3r DTqfGJOzGE90435stc5jJdHhfHQBijRfx5hoWQWtSHJF2w5uJPNDvI0lkKjaGVTBPzh6 /qanyRjbME7W8ucNOOuG45OUuF8rf7+D9icvBYJvl9aA1JihIK79cHh3mBYKDgF7/+sp 7NeTqiEgXYIXdFsDhDPjLz14PV5MJQWZKVLdpEwEDPKmI5ppZjrVVv21lNfF37vdpjQv jtFW/1caBTR2WlwBzTmO6qjKWA0yWkCjEaHSAM2p6UU37O34xGWnSrGy6qP7VIFDJbe4 sE9A== X-Gm-Message-State: AOAM530wnCJLtI9uZTK45XB2Ba0MTIJ9TYZMdpxDKFxu3MZw7rcdWPgr Q5qSsHSp1N0Tv06OAAoBP34= X-Google-Smtp-Source: ABdhPJwnCbZ6s6swHj0RW0g4MBZMoRxL+5uEW0Ap+ch1WTG+LATyWC4Dx0JMgN+mbiBWk9+6DhDozg== X-Received: by 2002:a63:c64f:: with SMTP id x15mr760054pgg.196.1609874201094; Tue, 05 Jan 2021 11:16:41 -0800 (PST) Received: from localhost ([211.108.35.36]) by smtp.gmail.com with ESMTPSA id p9sm10811pjb.3.2021.01.05.11.16.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Jan 2021 11:16:40 -0800 (PST) Date: Wed, 6 Jan 2021 04:16:38 +0900 From: Minwoo Im To: Chao Leng Subject: Re: [PATCH 1/6] blk-mq: introduce blk_mq_set_request_complete Message-ID: <20210105191638.GB4426@localhost.localdomain> References: <20210105071936.25097-1-lengchao@huawei.com> <20210105071936.25097-2-lengchao@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210105071936.25097-2-lengchao@huawei.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_141643_775123_B7B99192 X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me, linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hello, On 21-01-05 15:19:31, Chao Leng wrote: > In some scenarios, nvme need setting the state of request to > MQ_RQ_COMPLETE. So add an inline function blk_mq_set_request_complete. > For details, see the subsequent patches. > > Signed-off-by: Chao Leng > --- > include/linux/blk-mq.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h > index e7482e6ad3ec..cee72d31054d 100644 > --- a/include/linux/blk-mq.h > +++ b/include/linux/blk-mq.h > @@ -493,6 +493,11 @@ static inline int blk_mq_request_completed(struct request *rq) > return blk_mq_rq_state(rq) == MQ_RQ_COMPLETE; > } > > +static inline void blk_mq_set_request_complete(struct request *rq) > +{ > + WRITE_ONCE(rq->state, MQ_RQ_COMPLETE); > +} > + Maybe we can have this newly added helper with updating caller in blk_mq_complete_request_remote() also ? Thanks, _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme