From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511D6C433E0 for ; Wed, 6 Jan 2021 09:01:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF9C423100 for ; Wed, 6 Jan 2021 09:01:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF9C423100 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y9P8F6MU/6CBlCG/fyvoIvvNBb+nuIfQE7GoSZioVJs=; b=pE1dvBDFuAhAFledt133RxSGf sfV/YvajQ1kbtoloUGXcjZE5oyv8HRqdbV3gj+eR7UAQqTg9Q3mNen26FqSzERxyzSfkOP76mF66z 0Zars+hx66IcrBCc/biUFqBJdaK+X/WD1/t565hW5C1Y6mDhyrVA9V/t5+QtBMLBJmCcaVpMv1DxV t/huoQcb9xlLkmcfPWqkBiffJ6+6p+6TAKkPuowKt0rQPlPNiSh/sFh7bMakh0JhKlIbbSSwOn7V3 KvHrTNzi4jFueEJgn+iUVhlcL3LZWuoN1cItfOTz9uQsPjQirIXWAigmwtwFyWuHj0odFFUgkLb+Y YG92T8fZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx4gc-000709-MB; Wed, 06 Jan 2021 09:00:58 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx4ga-0006zo-Dc for linux-nvme@lists.infradead.org; Wed, 06 Jan 2021 09:00:57 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 5FEE068AFE; Wed, 6 Jan 2021 10:00:53 +0100 (CET) Date: Wed, 6 Jan 2021 10:00:53 +0100 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCH] nvme: trace: parse format nvm command in detail Message-ID: <20210106090053.GA32643@lst.de> References: <20210104155343.GA26034@michal-desk> <20210104160220.GB1024941@dhcp-10-100-145-180.wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210104160220.GB1024941@dhcp-10-100-145-180.wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_040056_613027_4EA999B8 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Krakowiak , Sagi Grimberg , linux-nvme@lists.infradead.org, Jens Axboe , Michal Krakowiak , Dan Williams , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Jan 04, 2021 at 08:02:20AM -0800, Keith Busch wrote: > Perhaps it's too late since we've already gone done this path in the > driver, but IMO, we should have only traced raw dwords without any > additional decoding. This would have allowed consistent output for all > kernel versions and resilient to future spec changes. Then that could > have made possible for a user space utility to do the decoding to a > human friendly format, kind of like what blkparse does for block layer > trace events. the block tracepoints actually contain pretty detailed decoding as well. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme