Re: [PATCH] nvme: trace: parse format nvm command in detail

Christoph Hellwig
2021-01-12T08:33:18Z

On Mon, Jan 11, 2021 at 09:15:52PM +0100, Michal Krakowiak wrote:
> Like Dan, I really appreciate having the trace parsed in the kernel. I
> understand the concerns. What about having both: detailed parsing and raw
> bytes? It does not seem to me like a big deal to append a field with the
> raw data even if detailed parsing is implemented. Let the parsing extends
> the raw data instead of replacing them. This will result in the detailed
> human-friendly output (which is nice to have) while not losing data in the
> future (in the case that a new unsupported by parser field appears).

That is how the kernel trace events work, including for the block layer.
blktrace is a separate piece of software that attaches to the raw
tracepoints and adds its own handling, so I don't think it is the right
comparism here.