Re: [PATCH] nvme: trace: parse format nvm command in detail

Keith Busch
2021-01-04T16:02:44Z

On Mon, Jan 04, 2021 at 04:53:43PM +0100, Michal Krakowiak wrote:
> FTrace does not parse NVMe commands consistently. There are commands
> that are being parsed in detail and commands for which the trace log
> contains only raw bytes of command dwords. Add detailed parsing of
> format nvm admin command to make the trace log more consistent and
> human-readable.

Perhaps it's too late since we've already gone done this path in the
driver, but IMO, we should have only traced raw dwords without any
additional decoding. This would have allowed consistent output for all
kernel versions and resilient to future spec changes. Then that could
have made possible for a user space utility to do the decoding to a
human friendly format, kind of like what blkparse does for block layer
trace events.