From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713E4C433E0 for ; Tue, 12 Jan 2021 08:09:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F023222D2C for ; Tue, 12 Jan 2021 08:09:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F023222D2C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jCrU1rwQFYcR9YL/hz4N+rxqlCmVCzJA5w3AL4V0CBM=; b=d8fMnFrDOUgVvqlfg0fEWRLTq vkGbGP3dTXl3tA+QPzY3eLEdXu63Uka/3o48IPCDieHJaheOk3IiFSV6qmWWv35wjsbiR+GuaHCl5 M6bS40NSwVUEhHY5fiYGSCLrMPAv2tGxG000t+20kd97C8Nt8663j9HxCLBWd5Qh/T5AxFoFHGCyd BfCJfXoPptcPIOvSgnJB6WSpmyo6BLqXYKK9w+weSHE5gT0XWFkpXHWjgfWmRR6BBaZTsZetUFlvk kmX8W/hLTQAR63wQML9ZAXi2KgyJobrmZce95B46KCZvO5WZlADGsDGnbIrK4exDpBjA0AJ0C32WI hkW3YM4YQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzEkA-0005oZ-E9; Tue, 12 Jan 2021 08:09:34 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzEk4-0005mp-Lg for linux-nvme@lists.infradead.org; Tue, 12 Jan 2021 08:09:31 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A74C967373; Tue, 12 Jan 2021 09:09:26 +0100 (CET) Date: Tue, 12 Jan 2021 09:09:26 +0100 From: Christoph Hellwig To: Minwoo Im Subject: Re: [PATCH 3/3] nvme: add parameter command_retry to enable retry Message-ID: <20210112080926.GD24949@lst.de> References: <20210108144659.7126-1-minwoo.im.dev@gmail.com> <20210108144659.7126-4-minwoo.im.dev@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210108144659.7126-4-minwoo.im.dev@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_030929_851358_33D3FD27 X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Jens Axboe , Christoph Hellwig , linux-nvme@lists.infradead.org, Sagi Grimberg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Jan 08, 2021 at 11:46:59PM +0900, Minwoo Im wrote: > This patch added a module parameter named command_retry to turn on the > command retry feature in this driver. If turning it on, > REQ3_FAILFAST_DRIVER will not be set to requests so that retry can be > reached out to nvme_retry_req() based on the module parameter. Why would we want to do that, and if so why only conditional on a module parameter? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme