From: Revanth Rajashekar <revanth.rajashekar@intel.com>
To: <linux-nvme@lists.infradead.org>
Cc: Keith Busch <kbusch@kernel.org>,
Revanth Rajashekar <revanth.rajashekar@intel.com>,
hch@lst.de, Jonathan Derrick <jonathan.derrick@intel.com>
Subject: [PATCH v2] nvme: Check the PRINFO bit and the Metadata size before deciding the host buffer length
Date: Tue, 12 Jan 2021 10:29:41 -0700 [thread overview]
Message-ID: <20210112172941.3911-1-revanth.rajashekar@intel.com> (raw)
According to NVMe spec v1.4, section 8.3.1, the PRINFO bit and
the metadata size play a vital role in deteriming the host buffer size.
If PRIFNO bit is set and MS==8, the host doesn't add the metadata buffer,
instead the controller adds it.
Changes from v1:
1. Remove the definition 'NVME_PRINFO_CTRL_BIT'
2. Remove variable 'control'
3. Remove test_bit and check the bit with the CPU arch's native endianness
Signed-off-by: Revanth Rajashekar <revanth.rajashekar@intel.com>
---
drivers/nvme/host/core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index f320273fc672..03261e0abdcc 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1546,6 +1546,11 @@ static int nvme_submit_io(struct nvme_ns *ns, struct nvme_user_io __user *uio)
meta_len = (io.nblocks + 1) * ns->ms;
metadata = nvme_to_user_ptr(io.metadata);
+ if (io.control & NVME_RW_PRINFO_PRACT && ns->ms == 8) {
+ meta_len = 0;
+ metadata = NULL;
+ }
+
if (ns->features & NVME_NS_EXT_LBAS) {
length += meta_len;
meta_len = 0;
--
2.17.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2021-01-12 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 17:29 Revanth Rajashekar [this message]
2021-01-12 18:39 ` [PATCH v2] nvme: Check the PRINFO bit and the Metadata size before deciding the host buffer length Christoph Hellwig
2021-01-13 16:57 ` Rajashekar, Revanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112172941.3911-1-revanth.rajashekar@intel.com \
--to=revanth.rajashekar@intel.com \
--cc=hch@lst.de \
--cc=jonathan.derrick@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox