From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C74C433E6 for ; Mon, 18 Jan 2021 17:49:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5E3920715 for ; Mon, 18 Jan 2021 17:49:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5E3920715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EjqmJUhcM7LYLr4t+0BERrBQleoPHG/8Vs3RFGdv028=; b=kkaE+QIfBRiU1daXcZ8mdPAXd mC8hCeffsZAmQ5m/RqwVhLnjD9GUSWWPNnX7v2cDftUdh0hcSRJ19eC0UOl6OqsALxoiwVb5vZLbe esSdNl05wAeI9EDMenS6mJ5Kh0t5/EZwV8E5dlXovkxLAuM21rdkRDc7lTM6EFX2Gn7tOknRAItrg E2Wrat1EU81USuHltTY4A13rXcknguH6ObfvCnaBLTHnnoeAHbeRc1QKvSLLMRfA3yP0cIlDWqewG a8S1aMPYbKYwI7r4DPBGTdW3yfaOPrSz6msEeZSnw/0OuJrrr0+0zuNMILqOCC/Bg8h8eBPMEERhC 3Qp928Qeg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1YeZ-0003oc-A7; Mon, 18 Jan 2021 17:49:23 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1YeT-0003o7-W9 for linux-nvme@lists.infradead.org; Mon, 18 Jan 2021 17:49:21 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 1409E6736F; Mon, 18 Jan 2021 18:49:14 +0100 (CET) Date: Mon, 18 Jan 2021 18:49:13 +0100 From: Christoph Hellwig To: Chao Leng Subject: Re: [PATCH v2 4/6] nvme-rdma: avoid IO error and repeated request completion Message-ID: <20210118174913.GA8700@lst.de> References: <20210107033149.15701-1-lengchao@huawei.com> <20210107033149.15701-5-lengchao@huawei.com> <07e41b4f-914a-11e8-5638-e2d6408feb3f@grimberg.me> <7b12be41-0fcd-5a22-0e01-8cd4ac9cde5b@huawei.com> <695b6839-5333-c342-2189-d7aaeba797a7@huawei.com> <4ff22d33-12fa-1f70-3606-54821f314c45@grimberg.me> <0b5c8e31-8dc2-994a-1710-1b1be07549c9@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0b5c8e31-8dc2-994a-1710-1b1be07549c9@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_124918_149574_1ACDCAE0 X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, Sagi Grimberg , linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Jan 18, 2021 at 11:22:16AM +0800, Chao Leng wrote: >> Well, certainly this one-shot always return 0 and complete the command >> with HOST_PATH error is not a good approach IMO > So what's the better option? Just complete the request with host path > error for non-ENOMEM and EAGAIN returned by the HBA driver? what HBA driver? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme