From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH V9 4/9] nvmet: add ZBD over ZNS backend support
Date: Mon, 18 Jan 2021 19:27:23 +0100 [thread overview]
Message-ID: <20210118182723.GD11082@lst.de> (raw)
In-Reply-To: <BYAPR04MB4965CE08B1DE8BC36585991686A90@BYAPR04MB4965.namprd04.prod.outlook.com>
On Wed, Jan 13, 2021 at 04:57:15AM +0000, Chaitanya Kulkarni wrote:
> >> /* command sets supported: NVMe command set: */
> >> ctrl->cap = (1ULL << 37);
> >> + if (IS_ENABLED(CONFIG_BLK_DEV_ZONED))
> >> + ctrl->cap |= (1ULL << 43);
> >> /* CC.EN timeout in 500msec units: */
> >> ctrl->cap |= (15ULL << 24);
> >> /* maximum queue entries supported: */
> > This needs to go into a separate patch for multiple command set support.
> > We can probably merge the CAP and CC bits with the CSI support, though.
> Do you mean previous patch ?
Yes.
> but we don't add handlers non-default I/O
> command set until this patch..
No, bit 43 just means the TP to support multiple comman sets is supported.
That infrastructure can be used even by controllers only supporting the
NVM command set.
> > bdev_is_zoned should be probably stubbed out for !CONFIG_BLK_DEV_ZONED
> > these days.
> Are you saying something like following in the prep patch ?or should
> just remove
> theIS_ENABLED(CONFIG_BLK_DEV_ZONED)part in above if?
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 028ccc9bdf8d..124086c1a0ba 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1570,6 +1570,9 @@ static inline bool bdev_is_zoned(struct
> block_device *bdev)
> {
> struct request_queue *q = bdev_get_queue(bdev);
>
> + if (!IS_ENABLED(CONFIG_BLK_DEV_ZONED))
> + return false;
> +
> if (q)
> return blk_queue_is_zoned(q);
blk_queue_is_zoned calls blk_queue_zoned_model, which is stubbed out
already. So no extra work should be required.
> /*
> * For ZBC and ZAC devices, writes into sequential zones must be aligned
> * to the device physical block size. So use this value as the *physical*
> * block size to avoid errors.
> */
See my reply to Damien.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-18 18:27 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 4:26 [PATCH V9 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
2021-01-12 4:26 ` [PATCH V9 1/9] block: export bio_add_hw_pages() Chaitanya Kulkarni
2021-01-12 5:40 ` Damien Le Moal
2021-01-12 7:24 ` Christoph Hellwig
2021-01-13 1:20 ` Chaitanya Kulkarni
2021-01-12 4:26 ` [PATCH V9 2/9] nvmet: add lba to sect conversion helpers Chaitanya Kulkarni
2021-01-12 5:08 ` Damien Le Moal
2021-01-18 18:19 ` Christoph Hellwig
2021-01-12 4:26 ` [PATCH V9 3/9] nvmet: add NVM command set identifier support Chaitanya Kulkarni
2021-01-12 7:27 ` Christoph Hellwig
2021-01-13 4:16 ` Chaitanya Kulkarni
2021-01-18 18:21 ` Christoph Hellwig
2021-01-12 4:26 ` [PATCH V9 4/9] nvmet: add ZBD over ZNS backend support Chaitanya Kulkarni
2021-01-12 5:32 ` Damien Le Moal
2021-01-12 6:11 ` Chaitanya Kulkarni
2021-01-12 6:31 ` Damien Le Moal
2021-01-12 7:48 ` Christoph Hellwig
2021-01-12 7:52 ` Damien Le Moal
2021-01-18 18:25 ` Christoph Hellwig
2021-01-19 0:02 ` Damien Le Moal
2021-01-19 4:28 ` Damien Le Moal
2021-01-19 6:15 ` hch
2021-01-13 4:57 ` Chaitanya Kulkarni
2021-01-18 18:27 ` Christoph Hellwig [this message]
2021-01-12 4:26 ` [PATCH V9 5/9] nvmet: add bio get helper for different backends Chaitanya Kulkarni
2021-01-12 5:37 ` Damien Le Moal
2021-01-12 5:55 ` Chaitanya Kulkarni
2021-01-12 7:33 ` Christoph Hellwig
2021-01-13 5:03 ` Chaitanya Kulkarni
2021-01-18 18:28 ` Christoph Hellwig
2021-01-19 4:57 ` Chaitanya Kulkarni
2021-01-12 4:26 ` [PATCH V9 6/9] nvmet: add bio init " Chaitanya Kulkarni
2021-01-12 5:40 ` Damien Le Moal
2021-01-12 5:57 ` Chaitanya Kulkarni
2021-01-12 6:27 ` Damien Le Moal
2021-01-12 7:33 ` Christoph Hellwig
2021-01-13 5:04 ` Chaitanya Kulkarni
2021-01-18 18:33 ` Christoph Hellwig
2021-01-12 4:26 ` [PATCH V9 7/9] nvmet: add bio put " Chaitanya Kulkarni
2021-01-12 4:26 ` [PATCH V9 8/9] nvmet: add common I/O length check helper Chaitanya Kulkarni
2021-01-12 7:35 ` Christoph Hellwig
2021-01-13 5:07 ` Chaitanya Kulkarni
2021-01-18 18:34 ` Christoph Hellwig
2021-01-12 4:26 ` [PATCH V9 9/9] nvmet: call nvmet_bio_done() for zone append Chaitanya Kulkarni
2021-01-12 7:36 ` Christoph Hellwig
2021-01-13 5:13 ` Chaitanya Kulkarni
2021-01-12 6:12 ` [PATCH V9 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
2021-02-10 22:42 ` Chaitanya Kulkarni
2021-02-11 7:20 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118182723.GD11082@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox