From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A906C433E0 for ; Wed, 20 Jan 2021 17:56:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F472223DB for ; Wed, 20 Jan 2021 17:56:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F472223DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eKYqHcrx2Ov73jDE5G9IxaQLLZRvQu2SqSIgaNxD9tU=; b=b4Wjh4sLJBLVZfFDOyHHGDOsZ dzJejWhT7tbk5qkzKMB/VlE/Yp9G+6+hJwQfi4LZJvjOdvX91CnJM4MkVFQxRsd+H5MUGS42bAgcb EYYE1EtrkH1pB+UPVW9vxaMz2LdDHzS7n8q8SmTtMn0OO2nYPqStalsU1UPCHo/YA0anb1U8hjwUC iPbWQI0CNc5gkRxCAf7eiFmOXNX1gG4jofYq5AoDIHAAM9UDg+tFdVY5SNRblXcXUMNIcS0PpqwIV E4q/UG0gLjI8LwWNlm+Sa3V6yTl1QUGAEDvF8xojI/Z01krdswvW8803tkqYNsSZDQOvxYzOuCWFH io6nne/sg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2Hib-0002kK-E9; Wed, 20 Jan 2021 17:56:33 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2HiT-0002iQ-D7 for linux-nvme@lists.infradead.org; Wed, 20 Jan 2021 17:56:26 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4BF8B68B05; Wed, 20 Jan 2021 18:56:20 +0100 (CET) Date: Wed, 20 Jan 2021 18:56:20 +0100 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCH 2/2] nvme-pci: fix error unwind in nvme_map_data Message-ID: <20210120175620.GA26100@lst.de> References: <20210120094915.3198346-1-hch@lst.de> <20210120094915.3198346-3-hch@lst.de> <20210120164824.GA21874@lst.de> <20210120174252.GA27657@redsun51.ssa.fujisawa.hgst.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210120174252.GA27657@redsun51.ssa.fujisawa.hgst.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_125625_551149_F55B3973 X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Orr , Christoph Hellwig , linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Jan 21, 2021 at 02:42:52AM +0900, Keith Busch wrote: > On Wed, Jan 20, 2021 at 05:48:24PM +0100, Christoph Hellwig wrote: > > On Wed, Jan 20, 2021 at 07:23:39AM -0800, Marc Orr wrote: > > > On Wed, Jan 20, 2021 at 1:49 AM Christoph Hellwig wrote: > > > > > > > > Properly unwind step by step using refactored helpers from nvme_unmap_data > > > > to avoid a potential double dma_unmap on a mapping failure. > > > > > > > > Reported-by: Marc Orr > > > > Signed-off-by: Christoph Hellwig > > > > > > Should these patches go to stable? > > > > Yes. I've added the proper fixes tag: > > > > Fixes: 7fe07d14f71f ("nvme-pci: merge nvme_free_iod into nvme_unmap_data") > > Patches look good. > > Reviewed-by: Keith Busch > > Just fyi, the 2/2 is the only one with the "Fixes" tag, but it depends > on 1/2 to compile. It applies cleanly to the recent stables, though, so > stable bot might have some trouble with it. patch 2 obviously depends on 1, the bot has been pretty good at figuring that out. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme