Re: [PATCH 08/35] monitor: add command line options to control logging

Hannes Reinecke
2021-02-04T07:05:03Z

On 1/26/21 9:32 PM, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> Standard syslog loglevels are used.
> Options:
>
> -S/--silent to suppress LOG_NOTICE
> -v/--verbose to enable LOG_INFO (overrides -S)
> -D/--debug to enable LOG_DEBUG (overrides -S, -v)
> -C/--clockstamps to enable time stamps on log messages.
>
> I tried to use short options that don't conflict with options
> from nvme connect-all, because many of those options might be
> useful for the monitor, too.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> monitor.c | 47 +++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 41 insertions(+), 6 deletions(-)
> ... and if you had moved the logging functionality prior to the monitor
code, this patch could be merged with the main monitor functionality, too.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer