Re: [PATCH v5 1/3] blk-mq: introduce blk_mq_set_request_complete

Christoph Hellwig
2021-02-04T15:36:51Z

On Thu, Feb 04, 2021 at 08:32:17AM -0700, Jens Axboe wrote:
> On 2/4/21 8:30 AM, Christoph Hellwig wrote:
> > On Thu, Feb 04, 2021 at 08:27:46AM -0700, Jens Axboe wrote:
> >> On 1/31/21 8:49 PM, Chao Leng wrote:
> >>> nvme drivers need to set the state of request to MQ_RQ_COMPLETE when
> >>> directly complete request in queue_rq.
> >>> So add blk_mq_set_request_complete.
> >>
> >> This is a bit iffy, but looks ok for the intended use case. We just have
> >> to be careful NOT to add frivolous users of it...
> >
> > Yes, that is my main issue with it. The current use case looks fine,
> > but I suspect every time someone else uses it it's probly going to be
> > as misuse. I've applied this to nvme-5.12 with the rest of the patches,
> > it should be on its way to you soon.
>
> Might benefit from a big fat comment on why you probably shouldn't
> be using it...

I actually reworded the comment a bit, this is the current version: