From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4350FC433E6 for ; Mon, 1 Feb 2021 03:50:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6D7D64E28 for ; Mon, 1 Feb 2021 03:50:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6D7D64E28 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2xkOu6gYrPacsovXNf1SDPSmaoRxZaWTJXGCuJfWIWc=; b=FiqYjHctB5z92Eoqc5ohuTEDW 3aEGbr0vmyuWY+KH/uHKiUQwNRh2qsTnSCiXuhxn4/vqsxp+tJwrvgWghaRTUyTBGkFNdUVUa2mvE nouRmy0exuLEkovpeSQHICmGTgCICdlpgLlgPsK6w8oxyzRD/QKiENeVPYwprGZvZgcxRShK71xYg d31n6BQdx2dnFNYlBDBRnfsA4WKvFdW67bsOG2nNReUg+PDAfdYPs7MHwBHU9nyhqV6THnqN0o2Bb 9vVjLiuKDxWEoJK7YfuORSGu9oxc2hNpymPgPQxeE3RvR5mLVsphclS/gxHpm63y81MRPw3HRJ6M1 tOm3U4vag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6QDq-0005uA-PG; Mon, 01 Feb 2021 03:49:54 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6QDj-0005sK-HU for linux-nvme@lists.infradead.org; Mon, 01 Feb 2021 03:49:49 +0000 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DTYnN10p5zlDX2; Mon, 1 Feb 2021 11:48:08 +0800 (CST) Received: from huawei.com (10.29.88.127) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Mon, 1 Feb 2021 11:49:43 +0800 From: Chao Leng To: Subject: [PATCH v5 3/3] nvme-rdma: avoid IO error for nvme native multipath Date: Mon, 1 Feb 2021 11:49:40 +0800 Message-ID: <20210201034940.18891-4-lengchao@huawei.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20210201034940.18891-1-lengchao@huawei.com> References: <20210201034940.18891-1-lengchao@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.29.88.127] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210131_224947_836489_EADBAC53 X-CRM114-Status: GOOD ( 12.58 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me, axboe@fb.com, kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Work with nvme native multipath, if a path related error occurs when queue_rq call HBA drive to send request, queue_rq will return BLK_STS_IOERR to blk-mq. The request is completed with BLK_STS_IOERR instead of fail over to retry. queue_rq need complete the request with NVME_SC_HOST_PATH_ERROR and set the state of request to MQ_RQ_COMPLETE, the request will fail over to retry if needed. Signed-off-by: Chao Leng --- drivers/nvme/host/rdma.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index b7ce4f221d99..5fc113dd3302 100644 --- a/drivers/nvme/host/rdma.c +++ b/drivers/nvme/host/rdma.c @@ -2084,8 +2084,19 @@ static blk_status_t nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx, err = nvme_rdma_post_send(queue, sqe, req->sge, req->num_sge, req->mr ? &req->reg_wr.wr : NULL); - if (unlikely(err)) + if (unlikely(err)) { + if (err == -EIO) { + /* + * Fail the reqest so upper layer can failover I/O + * if another path is available + */ + req->status = NVME_SC_HOST_PATH_ERROR; + blk_mq_set_request_complete(rq); + nvme_rdma_complete_rq(rq); + return BLK_STS_OK; + } goto err_unmap; + } return BLK_STS_OK; -- 2.16.4 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme