From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F27C433E0 for ; Mon, 1 Feb 2021 17:27:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 825EA64EAA for ; Mon, 1 Feb 2021 17:27:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 825EA64EAA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=87g4QxQIctDnrHinFGZKwSbD070rZumnAx2pC2+3b5w=; b=KLRIJJuyS/AAPKokxZS4rSb3B UAcS377CLJYzcGGVVmkXDaDSVHMIdwutsCEU0DmU99RexZ2+18nStakcKqsU2cVlXDCkMpqCvZiqd aZgr32nIUqtsmG0nU/HaOvpUW9ETqduXRQJAMltONQKcJ0lWK3De7CqBt5ZPV6sh5ckVJgSpYvPT2 hhqLz1HDl5OIK11653EshRVihnFsKoF7I64koLl274qRjbInu7RXw0sjNdkxy1jymtY9yMfTXv4JP cBpyezuGH0FRhgH8UZbhf7Y0SEuCooTEUD+tdvwnUsJpc4li2G881uADkwvhoEPz1at4Jtmfw7n21 8/fTUbofw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6cz9-0005v0-2e; Mon, 01 Feb 2021 17:27:35 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6cz6-0005ud-Ro for linux-nvme@lists.infradead.org; Mon, 01 Feb 2021 17:27:33 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BAA256736F; Mon, 1 Feb 2021 18:27:30 +0100 (CET) Date: Mon, 1 Feb 2021 18:27:30 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Subject: Re: [PATCH 03/10] nvmet: set error in nvmet_find_namespace() Message-ID: <20210201172730.GC12054@lst.de> References: <20210201054138.34324-1-chaitanya.kulkarni@wdc.com> <20210201054138.34324-4-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210201054138.34324-4-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_122733_437362_304144A4 X-CRM114-Status: UNSURE ( 9.06 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org This does look like a nice cleanup, but I think we also need to rename the function now that it does not return the nvmet_ns but only sets it in the nvmet_req structure. What about nvmet_req_find_namespace? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme