From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH 06/10] nvmet: add helper to report invalid opcode
Date: Mon, 1 Feb 2021 18:29:21 +0100 [thread overview]
Message-ID: <20210201172921.GE12054@lst.de> (raw)
In-Reply-To: <20210201054138.34324-7-chaitanya.kulkarni@wdc.com>
On Sun, Jan 31, 2021 at 09:41:34PM -0800, Chaitanya Kulkarni wrote:
> +static inline u16 nvmet_report_invalid_opcode(struct nvmet_req *req)
> +{
> + char *backend;
> +
> + if (req->ns->bdev)
> + backend = "bdev";
> + else if (req->ns->file)
> + backend = "file";
> + else if (nvmet_req_passthru_ctrl(req))
> + backend = "passthru";
> + else
> + backend = "unknown";
> +
> + pr_err("unhandled cmd %d on qid %d for %s backend\n",
> + req->cmd->common.opcode, req->sq->qid, backend);
I think we can just skip reporting the backend, as this doesn't
really add much value. In fact given that this can be triggered
remotely it should probably be downgraded to a pr_debug.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-01 17:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 5:41 [PATCH 00/10] nvmet: fixes and some cleanups Chaitanya Kulkarni
2021-02-01 5:41 ` [PATCH 01/10] nvmet: zeroout id-ns buffer for invalid nsid Chaitanya Kulkarni
2021-02-01 17:24 ` Christoph Hellwig
2021-02-02 0:12 ` Chaitanya Kulkarni
2021-02-02 9:38 ` Christoph Hellwig
2021-02-03 4:31 ` Chaitanya Kulkarni
2021-02-01 5:41 ` [PATCH 02/10] nvmet: return uniform error for invalid ns Chaitanya Kulkarni
2021-02-01 5:41 ` [PATCH 03/10] nvmet: set error in nvmet_find_namespace() Chaitanya Kulkarni
2021-02-01 17:27 ` Christoph Hellwig
2021-02-02 0:13 ` Chaitanya Kulkarni
2021-02-01 5:41 ` [PATCH 04/10] nvmet: remove nsid param from nvmet_find_namespace() Chaitanya Kulkarni
2021-02-01 17:28 ` Christoph Hellwig
2021-02-02 0:13 ` Chaitanya Kulkarni
2021-02-01 5:41 ` [PATCH 05/10] nvmet: remove extra variable in is-ns handler Chaitanya Kulkarni
2021-02-01 5:41 ` [PATCH 06/10] nvmet: add helper to report invalid opcode Chaitanya Kulkarni
2021-02-01 17:29 ` Christoph Hellwig [this message]
2021-02-02 0:14 ` Chaitanya Kulkarni
2021-02-02 9:39 ` Christoph Hellwig
2021-02-01 5:41 ` [PATCH 07/10] nvmet: use invalid cmd opcode helper Chaitanya Kulkarni
2021-02-01 5:41 ` [PATCH 08/10] " Chaitanya Kulkarni
2021-02-01 5:41 ` [PATCH 09/10] nvmet: use min of device_path and disk len Chaitanya Kulkarni
2021-02-01 5:41 ` [PATCH 10/10] nvme-loop: rename variable to get rid of the warn Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201172921.GE12054@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox