From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B36C433E0 for ; Wed, 3 Feb 2021 11:16:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B70A764F5D for ; Wed, 3 Feb 2021 11:16:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B70A764F5D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DyVBPl7bl1nG2+IBBmTRE59UWTfy+LHwUU9m4m3H3BQ=; b=gxG1YJQRrja/BGbtaR0g7/wam +CUl9pccJGJVGPvN+LILN09FmqFGcDHzd1LWil1CUXRkRO9/NzzwC74ZzGCliTRbm+HQoNhGLM4rE Qkd3KsQj729v7P9Mc+zq4lFnCa1UgZxh8Xv/jl64kIFDpNhsmvFb5y4JTXGoWhfycINgXCwF5VBvP ZymV9n4vRb2Qtd0UiKm+U6nXjakPmpMOgRyLSzzPkHmmFDpACUlBn4U1aOfDACIn+GGNlWQYfya4j CW9XqVzjE3SJXRKDvp3ouD9/FtWyfui5gsVG5ZmNW529yFwvEr2MN6VU4v3MBNazz0n+tSFfGGaFj Oqnel80fQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7G8Z-0000ot-6t; Wed, 03 Feb 2021 11:15:55 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7G8W-0000oG-PT for linux-nvme@lists.infradead.org; Wed, 03 Feb 2021 11:15:53 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id ACA1067357; Wed, 3 Feb 2021 12:15:48 +0100 (CET) Date: Wed, 3 Feb 2021 12:15:48 +0100 From: Christoph Hellwig To: Filippo Sironi Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk Message-ID: <20210203111548.GA11075@lst.de> References: <20210203094338.19473-1-sironi@amazon.de> <20210203095148.GA8897@lst.de> <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_061552_970579_607C1314 X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sagi@grimberg.me, serebrin@amazon.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org, Christoph Hellwig , dwmw@amazon.co.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Feb 03, 2021 at 12:12:31PM +0100, Filippo Sironi wrote: > I don't disagree on the first part of your sentence, this is a big > oversight. But it is not what your commit log suggests. > On the other hand, those controllers are out there and are in use by a lot > of customers. We can keep relying on luck, hoping that customers don't run > into troubles or we can merge a few lines of code :) Your patch does not just quirk a few controllers out there, but all current and future controllers with an Amazon vendor ID. We could probably talk about quirking an existing vendor ID or two as long as this doesn't happen for future hardware. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme